Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Stop ironic rebuilds" #4097

Merged
merged 1 commit into from Dec 21, 2023
Merged

Revert "Stop ironic rebuilds" #4097

merged 1 commit into from Dec 21, 2023

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Dec 18, 2023

Reverts #4093

@openshift-bot
Copy link

Validating 2 file(s)...
Validating images/ironic-agent.yml...
✅ Validated images/ironic-agent.yml
Validating images/ironic.yml...
✅ Validated images/ironic.yml

@joepvd
Copy link
Contributor Author

joepvd commented Dec 18, 2023

/hold
Pin needs to disappear from upstream

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2023
@elfosardo
Copy link

elfosardo commented Dec 18, 2023 •
edited

PRs to relax pins
openshift/ironic-image#441
openshift/ironic-image#442

@elfosardo
Copy link

/unhold
this can be merged now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@elfosardo
Copy link

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@elfosardo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joepvd joepvd added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 77acb11 into openshift-4.15 Dec 21, 2023
2 checks passed
@sosiouxme sosiouxme deleted the revert-4093-stop-ironic-rebuilds branch January 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joepvd @openshift-bot @elfosardo