Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-ups on golang and rhel transitions #4105

Merged

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Dec 20, 2023

No description provided.

@openshift-bot
Copy link

Validating 30 file(s)...
Validating images/atomic-openshift-cluster-autoscaler.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/atomic-openshift-cluster-autoscaler.yml
Returned error: Additional properties are not allowed ('canonical_builders_from_upstream' was unexpected)

@joepvd
Copy link
Contributor Author

joepvd commented Dec 20, 2023

/hold
Want to see if https://issues.redhat.com/browse/ART-7803 is fixable before merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
Copy link

@locriandev locriandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thegreyd
Copy link
Contributor

/lgtm

@joepvd
Copy link
Contributor Author

joepvd commented Dec 20, 2023

/approve

Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 20, 2023
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

New changes are detected. LGTM label has been removed.

@openshift-bot
Copy link

Validating 30 file(s)...
Validating images/atomic-openshift-cluster-autoscaler.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/atomic-openshift-cluster-autoscaler.yml
Returned error: Additional properties are not allowed ('canonical_builders_from_upstream' was unexpected)

@openshift-bot
Copy link

Validating 30 file(s)...
Validating images/atomic-openshift-cluster-autoscaler.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/atomic-openshift-cluster-autoscaler.yml
Returned error: Additional properties are not allowed ('canonical_builders_from_upstream' was unexpected)

@joepvd
Copy link
Contributor Author

joepvd commented Dec 20, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@joepvd joepvd added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit b7ba6c3 into openshift-eng:openshift-4.16 Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants