Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ose-azure-disk-csi-driver-operator to rhel-9 images #4198

Conversation

dobsonj
Copy link
Contributor

@dobsonj dobsonj commented Jan 12, 2024

The ART bot is fighting with itself to reconcile .ci-operator.yaml in the csi-operator repo:

openshift/csi-operator#114
openshift/csi-operator#115

This is because aws-ebs-csi-driver-operator uses rhel-9 while azure-disk-csi-driver-operator uses rhel-8. This PR bumps azure-disk-csi-driver-operator to rhel-9 so they'll be consistent.

/cc @openshift/storage

Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift-eng members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The ART bot is fighting with itself to reconcile .ci-operator.yaml in the csi-operator repo:

openshift/csi-operator#114
openshift/csi-operator#115

This is because aws-ebs-csi-driver-operator uses rhel-9 while azure-disk-csi-driver-operator uses rhel-8. This PR bumps azure-disk-csi-driver-operator to rhel-9 so they'll be consistent.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/ose-azure-disk-csi-driver-operator.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 48, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: CGit validation failed for images/ose-azure-disk-csi-driver-operator.yml (https://pkgs.devel.redhat.com/cgit/containers/ose-azure-disk-csi-driver-operator)
Returned error: Branch rhaos-4.16-rhel-9 not found in CGit cache

@dobsonj
Copy link
Contributor Author

dobsonj commented Jan 12, 2024

/hold for validation error

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@dobsonj
Copy link
Contributor Author

dobsonj commented Jan 17, 2024

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@gnufied
Copy link

gnufied commented Jan 17, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@gnufied: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/ose-azure-disk-csi-driver-operator.yml...
✅ Validated images/ose-azure-disk-csi-driver-operator.yml

@joepvd
Copy link
Contributor

joepvd commented Jan 17, 2024

/hold
we're scrambling to get 4.16 nightlies, let's be a bit patient with introducing more chaos, even if only rather small.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@thegreyd
Copy link
Contributor

tested this pr and got a green build - ose-azure-disk-csi-driver-operator-container-v4.16.0-202401171846.p0.g8b4dc8e.assembly.test
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@thegreyd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit acc1454 into openshift-eng:openshift-4.16 Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants