Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1515: Revert #4411 "[4.16] build enterprise-tests with golang 1.21" #4412

Merged
merged 1 commit into from Feb 19, 2024
Merged

TRT-1515: Revert #4411 "[4.16] build enterprise-tests with golang 1.21" #4412

merged 1 commit into from Feb 19, 2024

Conversation

stbenjam
Copy link

@stbenjam stbenjam commented Feb 19, 2024 •
edited by openshift-ci bot

Reverts #4411 ; tracked by TRT-1515

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

The bump to golang 1.21 is causing significant OOM problems, we're rejecting payloads on it now

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify metal payload jobs pass

CC: @locriandev

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift-eng#4411 from locriandev/4.16-en…
1ce72fa 
…terprise-tests"

This reverts commit e4b5ded, reversing
changes made to 6f4f60b.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4411 ; tracked by TRT-1515

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

The bump to golang 1.21 is causing significant OOM problems, we're rejecting payloads on it now

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify metal payload jobs pass

CC: @locriandev

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4411 ; tracked by TRT-1515

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

The bump to golang 1.21 is causing significant OOM problems, we're rejecting payloads on it now

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify metal payload jobs pass

CC: @locriandev

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

soltysh
soltysh approved these changes Feb 19, 2024
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
locriandev
locriandev reviewed Feb 19, 2024
View reviewed changes
Copy link

@locriandev locriandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: locriandev, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c59b0a8 into openshift-eng:openshift-4.16 Feb 19, 2024
2 checks passed
@derekhiggins derekhiggins mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locriandev locriandev locriandev left review comments

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stbenjam @openshift-ci-robot @soltysh @locriandev