Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3191: add etcd image dep to installer #4644

Closed
wants to merge 1 commit into from

Conversation

r4f4
Copy link

@r4f4 r4f4 commented Apr 10, 2024

With the transition from terraform to CAPI, the Installer has now to run a controlplane on the host with etcd. This first step builds an intermediary container image from which the Installer will be able to extract binaries during build time.

With the transition from terraform to CAPI, the Installer has now to run
a controlplane on the host with etcd. This first step builds an
intermediary container image from which the Installer will be able to
extract binaries during build time.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2024

@r4f4: This pull request references CORS-3191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

With the transition from terraform to CAPI, the Installer has now to run a controlplane on the host with etcd. This first step builds an intermediary container image from which the Installer will be able to extract binaries during build time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ximinhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/ose-installer-etcd-artifacts.yaml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 48, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: CGit validation failed for images/ose-installer-etcd-artifacts.yaml (https://pkgs.devel.redhat.com/cgit/containers/ose-installer-etcd-artifacts)
Returned error: Repo was not found in CGit cache.
If you didn't request a DistGit repo yet, please check https://mojo.redhat.com/docs/DOC-1168290
But if you already obtained one, make sure its name matches the YAML filename

@joepvd
Copy link
Contributor

joepvd commented Apr 26, 2024

/cherrypick openshift-4.17

@openshift-cherrypick-robot

@joepvd: once the present PR merges, I will cherry-pick it on top of openshift-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick openshift-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Author

r4f4 commented May 2, 2024

Closing in favor of #4774

@r4f4 r4f4 closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants