adding 408 - Request Timeout to list of retryable status codes (knati…

…ve-extensions#2160) (#256)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>

data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSender.java

@@ -201,6 +201,7 @@ static boolean isRetryableStatusCode(final int statusCode) {
     // From https://github.com/knative/specs/blob/c348f501de9eb998b4fd010c54d9127033ee41be/specs/eventing/data-plane.md#event-acknowledgement-and-delivery-retry
     return statusCode >= 500 || // Generic error
       statusCode == 404 || // Endpoint does not exist
+      statusCode == 408 || // Request Timeout
       statusCode == 409 || // Conflict / Processing in progress
       statusCode == 429;   // Too Many Requests / Overloaded
   }

data-plane/dispatcher/src/test/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSenderTest.java

@@ -77,7 +77,7 @@ public static Stream<Integer> nonRetryableStatusCodes() {
     return Stream.concat(
       Stream.concat(
         IntStream.range(200, 404).boxed(),
-        IntStream.range(405, 409).boxed()
+        IntStream.range(405, 408).boxed()
       ),
       Stream.concat(
         IntStream.range(410, 429).boxed(),
@@ -89,7 +89,7 @@ public static Stream<Integer> nonRetryableStatusCodes() {
   public static Stream<Integer> retryableStatusCodes() {
     return Stream.concat(
       IntStream.range(500, 600).boxed(),
-      IntStream.of(404, 409, 429).boxed()
+      IntStream.of(404, 408, 409, 429).boxed()
     );
   }
 }