-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart Index pod if does not have docker secret #1572
Restart Index pod if does not have docker secret #1572
Conversation
/retest |
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The failure is not related. We can merge it as it is. |
But we need that test no? |
The test is optional. And it fails for a reason unrelated to this PR. IMO, it's totally fine to merge it. |
ok let's merge. I will try again locally. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Slack discussion: https://coreos.slack.com/archives/CD87JDUB0/p1652801062140119?thread_ts=1652789871.107389&cid=CD87JDUB0