Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Index pod if does not have docker secret #1572

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented May 18, 2022

@openshift-ci openshift-ci bot requested review from alanfx and skonto May 18, 2022 07:21
@mgencur
Copy link
Contributor Author

mgencur commented May 18, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-upgrade-tests-aws-ocp-410 e0b372b link false /test 4.10-upgrade-tests-aws-ocp-410

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur
Copy link
Contributor Author

mgencur commented May 18, 2022

The failure is not related. We can merge it as it is.

@skonto
Copy link
Contributor

skonto commented May 18, 2022

But we need that test no?

@mgencur
Copy link
Contributor Author

mgencur commented May 18, 2022

But we need that test no?

The test is optional. And it fails for a reason unrelated to this PR. IMO, it's totally fine to merge it.

@skonto
Copy link
Contributor

skonto commented May 18, 2022

ok let's merge. I will try again locally.

@skonto
Copy link
Contributor

skonto commented May 18, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cf045d8 into openshift-knative:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants