Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StatefulSets for Kafka components #1666

Merged
merged 1 commit into from Aug 3, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 2, 2022

KafkaSource is moving to use StatefulSets in 1.27+.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

@pierDipi
Copy link
Member Author

pierDipi commented Aug 2, 2022

/cc @aliok @matzew

@openshift-ci openshift-ci bot requested review from aliok and matzew August 2, 2022 10:27
@openshift-ci openshift-ci bot added the approved label Aug 2, 2022
@pierDipi pierDipi force-pushed the support-statefulsets branch 2 times, most recently from aacd6c8 to b2c2995 Compare August 2, 2022 10:35
@pierDipi
Copy link
Member Author

pierDipi commented Aug 2, 2022

/test 4.10-upgrade-tests-aws-ocp-410

@pierDipi
Copy link
Member Author

pierDipi commented Aug 2, 2022

Probe test failed

/test 4.10-upgrade-tests-aws-ocp-410

@matzew
Copy link
Member

matzew commented Aug 2, 2022

LGTM

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

pierDipi commented Aug 3, 2022

/assign @aliok @matzew

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b009f0f into openshift-knative:main Aug 3, 2022
@pierDipi pierDipi deleted the support-statefulsets branch August 3, 2022 09:29
pierDipi added a commit to pierDipi/serverless-operator that referenced this pull request Aug 8, 2022
Related to openshift-knative#1666

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot pushed a commit that referenced this pull request Aug 8, 2022
Related to #1666

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants