[SRVKE-1193] Remove sugar resources #1669
Conversation
pierDipi
force-pushed
the
SRVKE-1193_Remove-sugar-controller-resources
branch
from
bba53b3
to
114e33e
Compare
|
/retest |
| // TestEventingReconcile runs Reconcile to verify if eventing resources are created/deleted. | ||
| func TestEventingReconcile(t *testing.T) { |
There was a problem hiding this comment.
I converted this test to an E2E test, see VerifyDashboards.
|
|
| @@ -53,10 +53,18 @@ func TestKnativeEventing(t *testing.T) { | |||
| VerifyNoDisallowedImageReference(t, caCtx, eventingNamespace) | |||
| }) | |||
|
|
|||
| t.Run("Verify sugar controller deletion", func(t *testing.T) { | |||
| if err := test.CheckNoDeployment(caCtx.Clients.Kube, eventingNamespace, "sugar-controller"); err != nil { | |||
There was a problem hiding this comment.
I think we can remove this in a future release.
| "github.com/openshift-knative/serverless-operator/test" | ||
| ) | ||
|
|
||
| func VerifySugarControllerDeletion(ctx *test.Context) upgrade.Operation { |
There was a problem hiding this comment.
likewise, to be removed in future release
- Remove deployment - Remove service for monitoring - Remove service monitor Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
SRVKE-1193_Remove-sugar-controller-resources
branch
from
a7ce03b
to
f4d36a1
Compare
|
@matzew fixed the 2 GH actions jobs otherwise Prow won't merge the PR |
force merge, FTW 😅 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com
Fixes JIRA #SRVKE-1193