New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.32] Update contract downgrade script to be standalone #2555
[release-1.32] Update contract downgrade script to be standalone #2555
Conversation
…f main contract configmaps already.
CI issues... |
/retest |
/retest |
/retest |
Co-authored-by: Calum Murray <cmurray@redhat.com>
--> /test 414-test-upgrade-aws-414 |
echo "$cmdata" | jq --arg new_data "$new_data" '.binaryData.data = $new_data' | kubectl apply -f - | ||
fi | ||
done | ||
|
||
# Trigger a reconcile of the related pods (see https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically) | ||
declare -a pods_app_labels=("kafka-broker-dispatcher" "kafka-broker-receiver" "kafka-channel-dispatcher" "kafka-channel-receiver" "kafka-source-dispatcher" "kafka-source-receiver") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should kafka-source-receiver
actually be kafka-sink-receiver
?
Testing these changes, I don't see the annotation on kafka-sink-receiver and the single test fails then:
--- PASS: TestServerlessUpgradeContinual/Run/KafkaBrokerContinualTest
--- FAIL: TestServerlessUpgradeContinual/Run/KafkaSinkSourceContinualTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sry. Copy&paste issue
/test 414-test-upgrade-aws-414 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5a25a16
into
openshift-knative:release-1.32
Update the contract downgrade script to: