Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.32] Update contract downgrade script to be standalone #2555

Conversation

creydr
Copy link
Member

@creydr creydr commented Mar 8, 2024

Update the contract downgrade script to:

  • include the main contract names already (so this can be run without parameters later from support without knowing the configmap names)
  • allow to set the namespace name (so this can be run on namespaced-broker configs too)

@openshift-ci openshift-ci bot requested review from lberk and ReToCode March 8, 2024 11:25
@creydr
Copy link
Member Author

creydr commented Mar 8, 2024

CI issues...
/retest

@creydr
Copy link
Member Author

creydr commented Mar 8, 2024

Could not resolve tag openshift_knative-eventing-src_knative-v1.11 in imagestream pipeline. error=timed out waiting for the condition

/retest

@creydr
Copy link
Member Author

creydr commented Mar 8, 2024

Could not resolve tag openshift_release_rhel-8-release-golang-1.21-openshift-4.16 in imagestream pipeline. error=timed out waiting for the condition
again?

/retest

@creydr
Copy link
Member Author

creydr commented Mar 8, 2024

/retest

@creydr
Copy link
Member Author

creydr commented Mar 11, 2024

@matzew @pierDipi @Cali0707: anybody of you see something obvious, why the tests fail? 🤔

Co-authored-by: Calum Murray <cmurray@redhat.com>
@creydr
Copy link
Member Author

creydr commented Mar 11, 2024

operation.go:102: Failed to get all KResources ready failed waiting for {TypeMeta:{Kind:KafkaSource APIVersion:sources.knative.dev/v1beta1} ObjectMeta:{Name:source-kafka-sink-source-continual-test GenerateName: Namespace:eventing-e2e3 SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ManagedFields:[]}} to become ready: timed out waiting for the condition
...
    client.go:152: Resource eventing-e2e3/source-kafka-sink-source-continual-test &TypeMeta{Kind:KafkaSource,APIVersion:sources.knative.dev/v1beta1,}:
        {
         "kind": "KafkaSource",
         "apiVersion": "sources.knative.dev/v1beta1",
         "metadata": {
          "name": "source-kafka-sink-source-continual-test",
          "namespace": "eventing-e2e3",
          "uid": "29376a26-a2fa-4d39-83d4-c99f77ae6fd5",
          "resourceVersion": "84948",
          "generation": 1,
          "creationTimestamp": "2024-03-11T12:00:34Z",
          "finalizers": [
           "kafkasources.sources.knative.dev"
          ],
         },
         "status": {
          "observedGeneration": 1,
          "conditions": [
           {
            "type": "ConsumerGroup",
            "status": "False",
            "lastTransitionTime": "2024-03-11T12:00:35Z",
            "reason": "BindInProgress"
           },
           {
            "type": "Ready",
            "status": "False",
            "lastTransitionTime": "2024-03-11T12:00:35Z",
            "reason": "BindInProgress"
           },
           {
            "type": "SinkProvided",
            "status": "Unknown",
            "lastTransitionTime": "2024-03-11T12:00:34Z",
            "reason": "SinkEmpty",
            "message": "Sink has resolved to empty."
           }
          ]
         }
        }

--> "message": "Sink has resolved to empty."

/test 414-test-upgrade-aws-414

echo "$cmdata" | jq --arg new_data "$new_data" '.binaryData.data = $new_data' | kubectl apply -f -
fi
done

# Trigger a reconcile of the related pods (see https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically)
declare -a pods_app_labels=("kafka-broker-dispatcher" "kafka-broker-receiver" "kafka-channel-dispatcher" "kafka-channel-receiver" "kafka-source-dispatcher" "kafka-source-receiver")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should kafka-source-receiver actually be kafka-sink-receiver ?
Testing these changes, I don't see the annotation on kafka-sink-receiver and the single test fails then:

--- PASS: TestServerlessUpgradeContinual/Run/KafkaBrokerContinualTest
--- FAIL: TestServerlessUpgradeContinual/Run/KafkaSinkSourceContinualTest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sry. Copy&paste issue

@pierDipi
Copy link
Member

/test 414-test-upgrade-aws-414

@pierDipi pierDipi requested a review from mgencur March 12, 2024 06:20
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a25a16 into openshift-knative:release-1.32 Mar 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants