Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.32] 🧹 Switch to Node 20 LTS #2564

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[release-1.32] 🧹 Switch to Node 20 LTS #2564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion olm-catalog/serverless-operator/project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ requirements:
# This value is used for CSV's min version validation.
minVersion: 1.25.0
golang: '1.21'
nodejs: 16.x
nodejs: 20.x
ocpVersion:
min: '4.12'
max: '4.14'
Expand Down
3 changes: 2 additions & 1 deletion openshift/ci-operator/build-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ RUN rm -rf $GOPATH/.cache
# Allow runtime users to add entries to /etc/passwd
RUN chmod g+rw /etc/passwd

RUN yum install -y https://rpm.nodesource.com/pub_16.x/el/7/x86_64/nodesource-release-el7-1.noarch.rpm
RUN yum install -y https://rpm.nodesource.com/pub_20.x/el/8/x86_64/nodesource-release-el8-1.noarch.rpm
RUN yum module disable -y nodejs
RUN yum install -y \
gcc-c++ \
make \
Expand Down
3 changes: 2 additions & 1 deletion templates/build-image.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ RUN rm -rf $GOPATH/.cache
# Allow runtime users to add entries to /etc/passwd
RUN chmod g+rw /etc/passwd

RUN yum install -y https://rpm.nodesource.com/pub___NODEJS_VERSION__/el/7/x86_64/nodesource-release-el7-1.noarch.rpm
RUN yum install -y https://rpm.nodesource.com/pub___NODEJS_VERSION__/el/8/x86_64/nodesource-release-el8-1.noarch.rpm
RUN yum module disable -y nodejs
RUN yum install -y \
gcc-c++ \
make \
Expand Down
2 changes: 2 additions & 0 deletions test/ui-e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ function check_node {
logger.error 'npm is required to run UI tests, install it.'
return 51
fi
logger.info "NodeJS version: $(node --version)"
logger.info "NPM version: $(npm --version)"
}

function archive_cypress_artifacts {
Expand Down
16 changes: 8 additions & 8 deletions test/ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@cypress/skip-test": "^2.6.1",
"cachedir": "^2.3.0",
"chalk": "^5.2.0",
"cypress": "^13.2.0",
"cypress": "^13.6.6",
"cypress-multi-reporters": "^1.6.3",
"diff": "^5.0.0",
"mocha": "^10.2.0",
Expand Down