Introduce install-for-mesh-e2e make target #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The make target installs products/dependencies that are required for running E2E tests with mesh. This is to enable running "installation" and "tests" in separate CI containers and report failures specificially for each phase. Running install and test separately would require these: make install-for-mesh-e2e make test-upstream-e2e-mesh-testonly
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mgencur can you check on the failures? (Just to get it in before the 1.33 cut) |
|
@creydr I have re-run the "Generated files are committed" and it passes now. This PR is ready for a merge. |
openshift-merge-bot
bot
merged commit 7d60f86
into
openshift-knative:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The make target installs products/dependencies that are required for running E2E tests with mesh.
This is to enable running "installation" and "tests" in separate CI containers and report failures specifically for each phase. Running install and test separately would require these:
Related slack discussion with product-to-product QE.
Proposed Changes