Remove FIPS annotation #2643
Remove FIPS annotation #2643
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/cherry-pick release-1.33 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -3,7 +3,7 @@ kind: ClusterServiceVersion | |||
| metadata: | |||
| annotations: | |||
| operatorframework.io/suggested-namespace: "openshift-serverless" | |||
| operators.openshift.io/infrastructure-features: '["disconnected", "fips", "proxy-aware"]' | |||
| operators.openshift.io/infrastructure-features: '["disconnected", "proxy-aware"]' | |||
| operators.openshift.io/valid-subscription: '["OpenShift Container Platform", "OpenShift Platform Plus"]' | |||
There was a problem hiding this comment.
Hi @pierDipi can you please also add below annotations,
features.operators.openshift.io/disconnected: "true"
features.operators.openshift.io/fips-compliant: "false"
features.operators.openshift.io/proxy-aware: "true"
features.operators.openshift.io/tls-profiles: "false"
features.operators.openshift.io/token-auth-aws: "false"
features.operators.openshift.io/token-auth-azure: "false"
features.operators.openshift.io/token-auth-gcp: "false"
There was a problem hiding this comment.
I think those can be added as a separate PR
There was a problem hiding this comment.
Okay, I'll open a PR with the above changes.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaustubh-pande, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3e6b2db
into
openshift-knative:main
|
@pierDipi: new pull request created: #2649 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is the follow up to the temporary removal of the FIPS support for 1.33+ until we know when we can support it back