Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create prometheus token instead of expecting it to exist #2673

Merged
merged 2 commits into from
May 27, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented May 23, 2024

The behaviour changed across OCP versions. With 4.10 and older it was recommended to get the existing token. For later versions it's recommended to create a new token every time. And on 4.16 the older aproach doesn't work anymore.

Fixes https://issues.redhat.com/browse/SRVCOM-3132

Proposed Changes

  • Create a new token every time.

The behaviour changed across OCP versions. With 4.10 and older it was
recommended to get the existing token. For later versions it's
recommended to create a new token every time. And on 4.16 the older
aproach doesn't work anymore.
@mgencur
Copy link
Contributor Author

mgencur commented May 23, 2024

/test ?

@openshift-ci openshift-ci bot requested review from dsimansk and pierDipi May 23, 2024 07:20
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@mgencur: The following commands are available to trigger required jobs:

  • /test 412-images
  • /test 412-operator-e2e-aws-412
  • /test 412-test-upgrade-aws-412
  • /test 415-aws-ovn-images
  • /test 415-azure-images
  • /test 415-gcp-images
  • /test 415-hypershift-images
  • /test 415-images
  • /test 415-operator-e2e-aws-415
  • /test 415-osd-images
  • /test 415-single-node-images
  • /test 415-test-upgrade-aws-415
  • /test 415-vsphere-images
  • /test 416-images
  • /test 416-operator-e2e-aws-416
  • /test 416-test-upgrade-aws-416
  • /test ocp4.14-lp-interop-images
  • /test ocp4.14-lp-rosa-classic-images
  • /test ocp4.15-lp-interop-images
  • /test ocp4.15-lp-rosa-classic-images
  • /test ocp4.16-lp-interop-images
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test 412-kitchensink-e2e-aws-412
  • /test 412-kitchensink-upgrade-aws-412
  • /test 412-mesh-e2e-aws-412
  • /test 412-mesh-upgrade-aws-412
  • /test 412-ui-e2e-aws-412
  • /test 412-upstream-e2e-aws-412
  • /test 412-upstream-e2e-kafka-aws-412
  • /test 415-kitchensink-e2e-aws-415
  • /test 415-kitchensink-upgrade-aws-415
  • /test 415-mesh-e2e-aws-415
  • /test 415-mesh-upgrade-aws-415
  • /test 415-ui-e2e-aws-415
  • /test 415-upstream-e2e-aws-415
  • /test 415-upstream-e2e-kafka-aws-415
  • /test 416-kitchensink-e2e-aws-416
  • /test 416-kitchensink-upgrade-aws-416
  • /test 416-mesh-e2e-aws-416
  • /test 416-mesh-upgrade-aws-416
  • /test 416-ui-e2e-aws-416
  • /test 416-upstream-e2e-aws-416
  • /test 416-upstream-e2e-kafka-aws-416

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-serverless-operator-main-415-images
  • pull-ci-openshift-knative-serverless-operator-main-415-operator-e2e-aws-415
  • pull-ci-openshift-knative-serverless-operator-main-415-test-upgrade-aws-415
  • pull-ci-openshift-knative-serverless-operator-main-415-upstream-e2e-aws-415
  • pull-ci-openshift-knative-serverless-operator-main-415-upstream-e2e-kafka-aws-415
  • pull-ci-openshift-knative-serverless-operator-main-ocp4.14-lp-rosa-classic-images
  • pull-ci-openshift-knative-serverless-operator-main-ocp4.15-lp-rosa-classic-images
  • pull-ci-openshift-knative-serverless-operator-main-unit-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mgencur
Copy link
Contributor Author

mgencur commented May 23, 2024

/test 416-operator-e2e-aws-416
/test 412-operator-e2e-aws-412

@mgencur
Copy link
Contributor Author

mgencur commented May 23, 2024

/cherry-pick release-1.33

@openshift-cherrypick-robot
Copy link
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mgencur
Copy link
Contributor Author

mgencur commented May 23, 2024

/test 416-operator-e2e-aws-416

Copy link
Contributor

openshift-ci bot commented May 23, 2024

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-operator-e2e-aws-416 6cb5371 link true /test 416-operator-e2e-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mgencur
Copy link
Contributor Author

mgencur commented May 23, 2024

The failures on OCP 4.16 are unrelated to my changes. Failed while waiting for a ServiceAccount to be deleted in these:

test/extensione2erekt: TestKafkaSourceBinaryEvent
test/extensione2erekt: TestSourceChannelBasedKafkaBrokerKsvc

@maschmid
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur mgencur merged commit 473a9c5 into openshift-knative:main May 27, 2024
11 of 13 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@mgencur: new pull request created: #2675

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants