-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create prometheus token instead of expecting it to exist #2673
Create prometheus token instead of expecting it to exist #2673
Conversation
The behaviour changed across OCP versions. With 4.10 and older it was recommended to get the existing token. For later versions it's recommended to create a new token every time. And on 4.16 the older aproach doesn't work anymore.
/test ? |
@mgencur: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test 416-operator-e2e-aws-416 |
/cherry-pick release-1.33 |
@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test 416-operator-e2e-aws-416 |
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The failures on OCP 4.16 are unrelated to my changes. Failed while waiting for a ServiceAccount to be deleted in these:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maschmid, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur: new pull request created: #2675 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The behaviour changed across OCP versions. With 4.10 and older it was recommended to get the existing token. For later versions it's recommended to create a new token every time. And on 4.16 the older aproach doesn't work anymore.
Fixes https://issues.redhat.com/browse/SRVCOM-3132
Proposed Changes