New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use multiarch Golang builder #650
base: release-v1.12-bak
Are you sure you want to change the base?
[WIP] Use multiarch Golang builder #650
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm not sure if the new images are used in tests running on this PR. Maybe we also need to update the CI config:https://github.com/openshift/release/blob/master/ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.12__414.yaml#L2 |
Note to self. Other repositories like Eventing, EKB use the following to generate the dockerfiles:
So, the image needs to be updated there and the generate command needs to be re-run via github action "Run Makefile target" on openshift-knative/hack |
802e61d
to
0f9ca28
Compare
We might skip 1.12 branch correct? |
What do you mean by that? Do you mea skipping release-v1.12 branch or OCP 4.12 ? |
/retest-required |
What this PR does / why we need it:
Support ARM and be able to build Serving images in on a heterogenous cluster in CI.
Link to Slack thread where this new image was mentioned.
Note: The new image is available only in CI. If somebody wants to use those Dockerfiles and built images locally they need to have an authfile in json format (it's possible to download it from a running CI job).
Image metadata:
Which issue(s) this PR fixes:
JIRA: https://issues.redhat.com/browse/SRVKS-1024
Does this PR needs for other branches:
release-v1.13, main
/cherry-pick release-v1.13
/cherry-pick main
Does this PR (patch) needs to update/drop in the future?:
NONE