[RELEASE-1.14] Backport: Integrate net-certmanager in Serving #695
Conversation
* integrate net-certmanager in Serving * Revert "disable kourier-tls (knative#15053)" This reverts commit 8bda840. * fix imports * add netcert conformance tests * fix vendor * add vendor networking test files * some fixes + rebase * fixes * add crd check * sym link * fix vendor * move reconciler * fix style * empty * move to pkg/client (cherry picked from commit 6ccb82f)
ReToCode
changed the title
|
/override "Validate / Lint" weird GH stuff again. |
|
@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override "Lint" |
|
@ReToCode: Overrode contexts on behalf of ReToCode: Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ReToCode let's wait for the CI? |
|
/override "ci/prow/415-test-e2e-tls-aws-415" |
|
@ReToCode: Overrode contexts on behalf of ReToCode: ci/prow/415-test-e2e-tls-aws-415 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@skonto now with CI, we skip tls stuff, as it needs S-O changes. I'll work on those next. |
|
/override "Lint" |
|
@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1846148
into
openshift-knative:release-v1.14
Changes
/assign @skonto