OCPBUGS-3885: Fix post timeout reconcile

[jc-rh]

• Set completed timestamp for the timed out case too and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout mistakenly

[openshift-ci-robot]

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jc-rh]

/assign @fontivan

[fontivan]

/approve

[openshift-ci-robot]

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

• Set completed time out the timed out case and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout by mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

• Set completed time out the timed out case and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout by mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

• Set completed timestamp for the timed out case too and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout by mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

• Set completed timestamp for the timed out case too and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout by mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

• Set completed timestamp for the timed out case too and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jc-rh: This pull request references Jira Issue OCPBUGS-3885, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

• Set completed timestamp for the timed out case too and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sabbir-47]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan, sabbir-47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fontivan,sabbir-47]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sabbir-47]

/lgtm

[openshift-ci-robot]

@jc-rh: All pull requests linked via external trackers have merged:

• openshift-kni/cluster-group-upgrades-operator#388

Jira Issue OCPBUGS-3885 has been moved to the MODIFIED state.

In response to this:

• Set completed timestamp for the timed out case too and prevent re-executing post timeout handling which sometimes causes infinite reconcile loop and duplicate cluster status entries
• Re-order the succeed condition check so that the prep phase logic doesn't get executed post timeout mistakenly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jc-rh]

/cherrypick release-4.12

[openshift-cherrypick-robot]

@jc-rh: new pull request created: #389

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.