OCPBUGS-3779: support only image or version in ClusterVersion when doing ocp precache #399
Conversation
|
@pixelsoccupied: This pull request references Jira Issue OCPBUGS-3779, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pixelsoccupied
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@pixelsoccupied: This pull request references Jira Issue OCPBUGS-3779, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
pixelsoccupied
force-pushed
the
precache-support-only-image-or-version-ocp
branch
from
cbfe858
to
2b00e52
Compare
pixelsoccupied
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/jira refresh |
|
@pixelsoccupied: This pull request references Jira Issue OCPBUGS-3779, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
pixelsoccupied
force-pushed
the
precache-support-only-image-or-version-ocp
branch
from
2b00e52
to
7f09a0c
Compare
…ing ocp precache refactor code to support cases and add unit tests add http mock reply when trying to make external calls remove the extra check update logic to handle when CV cr is not present improve check for spec and add additional test make sure ClusterVersion is present add const to where policies are changed, add another test make sure that empty strings are ok and make polcies minimal make the upstearm test url more streamlined and obvious that no external calls are being made to test
pixelsoccupied
force-pushed
the
precache-support-only-image-or-version-ocp
branch
from
7f09a0c
to
bdfb0e1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jc-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pixelsoccupied: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-3779 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.12 |
|
@pixelsoccupied: new pull request created: #400 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- single external only after CR validation
- no calls if user provides the Spec.DesiredUpdate.image
/cc @jc-rh @fontivan