Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-4704: Include already compliant polices for pre-caching #401

Merged
merged 6 commits into from Dec 16, 2022

Conversation

jc-rh
Copy link
Member

@jc-rh jc-rh commented Dec 15, 2022

Also added a kuttl test with the catalog source policy and one of the subscription policy being compliant prior to the upgrade

@jc-rh jc-rh changed the title Include already compliant polices for pre-caching OCPBUGS-4704: Include already compliant polices for pre-caching Dec 15, 2022
@openshift-ci-robot
Copy link

@jc-rh: This pull request references Jira Issue OCPBUGS-4704, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Also added a kuttl test with the catalog source policy and one of the subscription policy being compliant prior to the upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2022

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jc-rh: This pull request references Jira Issue OCPBUGS-4704, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Also added a kuttl test with the catalog source policy and one of the subscription policy being compliant prior to the upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jc-rh
Copy link
Member Author

jc-rh commented Dec 15, 2022

/assign @fontivan

@jc-rh
Copy link
Member Author

jc-rh commented Dec 15, 2022

/cc @pixelsoccupied

@fontivan
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@pixelsoccupied
Copy link
Contributor

New change lgtm -- but GitHub still complaining about the missing the end of line. Can you check what's happening there?

Screen Shot 2022-12-16 at 9 13 47 AM

@jc-rh
Copy link
Member Author

jc-rh commented Dec 16, 2022

New change lgtm -- but GitHub still complaining about the missing the end of line. Can you check what's happening there?

Screen Shot 2022-12-16 at 9 13 47 AM

Last line wasn't empty. Good now.

Copy link
Contributor

@pixelsoccupied pixelsoccupied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple of more end of file line warnings to squash

@pixelsoccupied
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9d2695a into openshift-kni:main Dec 16, 2022
@openshift-ci-robot
Copy link

@jc-rh: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4704 has been moved to the MODIFIED state.

In response to this:

Also added a kuttl test with the catalog source policy and one of the subscription policy being compliant prior to the upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jc-rh
Copy link
Member Author

jc-rh commented Dec 19, 2022

/cherrypick release-4.12

@openshift-cherrypick-robot

@jc-rh: new pull request created: #402

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants