Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-3210: Avoid processing subscription with mustnothave compliancetype #422

Conversation

sudomakeinstall2
Copy link
Collaborator

If complianceType of an object is mustnothave it won't be added to ManagedPolicyContent, so controller won't try to approve installplan for it.

Signed-off-by: Saeid Askari saskari@redhat.com

If compliancetype of an object is mustnothave it won't be added to
ManagedPolicyContent, so controller won't try to approve installplan
for it.

Signed-off-by: Saeid Askari <saskari@redhat.com>
@sudomakeinstall2 sudomakeinstall2 changed the title Avoid processing subscription with mustnothave compliancetype OCPBUGS-3210: Avoid processing subscription with mustnothave compliancetype Feb 2, 2023
@openshift-ci-robot
Copy link

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-3210, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If complianceType of an object is mustnothave it won't be added to ManagedPolicyContent, so controller won't try to approve installplan for it.

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2
Copy link
Collaborator Author

/jira refresh

@openshift-ci-robot
Copy link

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-3210, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-3210, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@sudomakeinstall2
Copy link
Collaborator Author

/test integration

@openshift-merge-robot openshift-merge-robot merged commit bdd0a76 into openshift-kni:main Feb 2, 2023
@openshift-ci-robot
Copy link

@sudomakeinstall2: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3210 has been moved to the MODIFIED state.

In response to this:

If complianceType of an object is mustnothave it won't be added to ManagedPolicyContent, so controller won't try to approve installplan for it.

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2
Copy link
Collaborator Author

/cherrypick release-4.12

@openshift-cherrypick-robot

@sudomakeinstall2: new pull request created: #425

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants