Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-6944: recovery: Update container checks in upgrade-recovery.sh #434

Merged

Conversation

donpenney
Copy link
Contributor

The upgrade-recovery.sh tool uses "crictl ps" to check container status, but the format of the ps output has been updated. Rather than screen-scraping for a specific column, this update changes the script to use "crictl ps -o json", using "jq" to pull the desired data from the output.

Signed-off-by: Don Penney dpenney@redhat.com

/cc @jc-rh @Missxiaoguo @sabbir-47

The upgrade-recovery.sh tool uses "crictl ps" to check container status,
but the format of the ps output has been updated. Rather than
screen-scraping for a specific column, this update changes the script to
use "crictl ps -o json", using "jq" to pull the desired data from the
output.

Signed-off-by: Don Penney <dpenney@redhat.com>
@openshift-ci-robot
Copy link

@donpenney: This pull request references Jira Issue OCPBUGS-6944, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The upgrade-recovery.sh tool uses "crictl ps" to check container status, but the format of the ps output has been updated. Rather than screen-scraping for a specific column, this update changes the script to use "crictl ps -o json", using "jq" to pull the desired data from the output.

Signed-off-by: Don Penney dpenney@redhat.com

/cc @jc-rh @Missxiaoguo @sabbir-47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donpenney
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@donpenney: This pull request references Jira Issue OCPBUGS-6944, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (josclark@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Missxiaoguo Missxiaoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@jc-rh
Copy link
Member

jc-rh commented Feb 8, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@donpenney
Copy link
Contributor Author

/override ci/prow/integration

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

@donpenney: Overrode contexts on behalf of donpenney: ci/prow/integration

In response to this:

/override ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 44cd450 into openshift-kni:main Feb 8, 2023
@openshift-ci-robot
Copy link

@donpenney: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6944 has been moved to the MODIFIED state.

In response to this:

The upgrade-recovery.sh tool uses "crictl ps" to check container status, but the format of the ps output has been updated. Rather than screen-scraping for a specific column, this update changes the script to use "crictl ps -o json", using "jq" to pull the desired data from the output.

Signed-off-by: Don Penney dpenney@redhat.com

/cc @jc-rh @Missxiaoguo @sabbir-47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jc-rh
Copy link
Member

jc-rh commented Feb 8, 2023

/cherrypick release-4.12

1 similar comment
@jc-rh
Copy link
Member

jc-rh commented Feb 8, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot

@jc-rh: new pull request created: #436

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants