New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-6944: recovery: Update container checks in upgrade-recovery.sh #434
OCPBUGS-6944: recovery: Update container checks in upgrade-recovery.sh #434
Conversation
The upgrade-recovery.sh tool uses "crictl ps" to check container status, but the format of the ps output has been updated. Rather than screen-scraping for a specific column, this update changes the script to use "crictl ps -o json", using "jq" to pull the desired data from the output. Signed-off-by: Don Penney <dpenney@redhat.com>
@donpenney: This pull request references Jira Issue OCPBUGS-6944, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@donpenney: This pull request references Jira Issue OCPBUGS-6944, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (josclark@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jc-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/integration |
@donpenney: Overrode contexts on behalf of donpenney: ci/prow/integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@donpenney: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-6944 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.12 |
1 similar comment
/cherrypick release-4.12 |
@jc-rh: new pull request created: #436 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The upgrade-recovery.sh tool uses "crictl ps" to check container status, but the format of the ps output has been updated. Rather than screen-scraping for a specific column, this update changes the script to use "crictl ps -o json", using "jq" to pull the desired data from the output.
Signed-off-by: Don Penney dpenney@redhat.com
/cc @jc-rh @Missxiaoguo @sabbir-47