Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-7477: Keep conditions in order of the status transition time #467

Merged
merged 1 commit into from Feb 14, 2023
Merged

[release-4.12] OCPBUGS-7477: Keep conditions in order of the status transition time #467

merged 1 commit into from Feb 14, 2023

Conversation

sudomakeinstall2
Copy link
Collaborator

…(#438)

  • OCPBUGS-7217: Conditions are in order of the time updated

When setting condition, if the condition is changed it should be the last condition in the list, so that printercolumn works as expected

Signed-off-by: Saeid Askari saskari@redhat.com

  • Add unit test

Signed-off-by: Saeid Askari saskari@redhat.com

Signed-off-by: Saeid Askari saskari@redhat.com

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

@sudomakeinstall2: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-7217: Keep conditions in order of the status transition time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-7217, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-7217 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…(#438)

  • OCPBUGS-7217: Conditions are in order of the time updated

When setting condition, if the condition is changed it should be the last condition in the list, so that printercolumn works as expected

Signed-off-by: Saeid Askari saskari@redhat.com

  • Add unit test

Signed-off-by: Saeid Askari saskari@redhat.com

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2 sudomakeinstall2 changed the title [release-4.12] OCPBUGS-7217: Keep conditions in order of the status transition time [release-4.12] OCPBUGS-7477: Keep conditions in order of the status transition time Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

@sudomakeinstall2: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-7477: Keep conditions in order of the status transition time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-7477, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.12.0" instead
  • expected Jira Issue OCPBUGS-7477 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…(#438)

  • OCPBUGS-7217: Conditions are in order of the time updated

When setting condition, if the condition is changed it should be the last condition in the list, so that printercolumn works as expected

Signed-off-by: Saeid Askari saskari@redhat.com

  • Add unit test

Signed-off-by: Saeid Askari saskari@redhat.com

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2
Copy link
Collaborator Author

/jira refresh

@openshift-ci-robot
Copy link

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-7477, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.12.0" instead
  • expected Jira Issue OCPBUGS-7477 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2
Copy link
Collaborator Author

/jira refresh

@openshift-ci-robot
Copy link

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-7477, which is invalid:

  • expected dependent Jira Issue OCPBUGS-7217 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2
OCPBUGS-7217: Keep conditions in order of the status transition time (o…
a26cb34 
…penshift-kni#438)

* OCPBUGS-7217: Conditions are in order of the time updated

When setting condition, if the condition is changed it should be
the last condition in the list, so that printercolumn works
as expected

Signed-off-by: Saeid Askari <saskari@redhat.com>

* Add unit test

Signed-off-by: Saeid Askari <saskari@redhat.com>

---------

Signed-off-by: Saeid Askari <saskari@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 752b9ee into openshift-kni:release-4.12 Feb 14, 2023
@openshift-ci-robot
Copy link

@sudomakeinstall2: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7477 has been moved to the MODIFIED state.

In response to this:

…(#438)

  • OCPBUGS-7217: Conditions are in order of the time updated

When setting condition, if the condition is changed it should be the last condition in the list, so that printercolumn works as expected

Signed-off-by: Saeid Askari saskari@redhat.com

  • Add unit test

Signed-off-by: Saeid Askari saskari@redhat.com

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jc-rh jc-rh mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc-rh jc-rh jc-rh approved these changes

@danielmellado danielmellado Awaiting requested review from danielmellado

@irinamihai irinamihai Awaiting requested review from irinamihai

Assignees

@jc-rh jc-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sudomakeinstall2 @openshift-ci-robot @jc-rh @openshift-merge-robot