New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.13] OCPBUGS-8525: Wait for soakSeconds
after policy becomes compliant before moving on from policy
#496
Conversation
If a policy has the `soakSeconds` annotation, the controller will wait for the specified number of seconds after the first time it observes that the cluster is compliant with that policy before moving on from that policy. The controller will set `status.status.currentBatchRemediationProgress.clusterName.firstCompliantAt` the first time it observes that the cluster is compliant with the policy. In the following reconciliations, if the requested number of seconds has passed since firstCompliantAt, and the cluster remains compliant with the policy, the controller will move on from that policy. Signed-off-by: Saeid Askari <saskari@redhat.com>
@openshift-cherrypick-robot: Jira Issue OCPBUGS-7540 has been cloned as Jira Issue OCPBUGS-8525. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
soakSeconds
after policy becomes compliant before moving on from policysoakSeconds
after policy becomes compliant before moving on from policy
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8525, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jc-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-8525: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8525 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.12 |
@jc-rh: #496 failed to apply on top of branch "release-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #481
/assign jc-rh