Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-11769: Identify managed policies with ambiguous names (#556) #578

Merged
merged 1 commit into from
Jun 1, 2023
Merged

OCPBUGS-11769: Identify managed policies with ambiguous names (#556) #578

merged 1 commit into from
Jun 1, 2023

Conversation

irinamihai
Copy link
Collaborator

Differentiate between managed policies with the same name in different namespaces:

  • determine all the namespaces where we can find managed policies
  • if there is at least one managed policy name that can be found in more than one namespace fail the CGU validation and include a condition message that contains the conflicting policy names and namespaces

Cleanup KUTTL child policies (#560)

Description:

  • child policies that are not properly cleaned up cause false failure for other KUTTL tests

@irinamihai
OCPBUGS-11769: Identify managed policies with ambiguous names (opensh…
e0ea65f 
…ift-kni#556)

Differentiate between managed policies with the same name in
different namespaces:
- determine all the namespaces where we can find managed policies
- if there is at least one managed policy name that can be found
  in more than one namespace fail the CGU validation and include a
  condition message that contains the conflicting policy names and
  namespaces

Cleanup KUTTL child policies (openshift-kni#560)

Description:
- child policies that are not properly cleaned up cause false
  failure for other KUTTL tests
@openshift-ci-robot
Copy link

@irinamihai: This pull request references Jira Issue OCPBUGS-11769, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-11769 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Differentiate between managed policies with the same name in different namespaces:

  • determine all the namespaces where we can find managed policies
  • if there is at least one managed policy name that can be found in more than one namespace fail the CGU validation and include a condition message that contains the conflicting policy names and namespaces

Cleanup KUTTL child policies (#560)

Description:

  • child policies that are not properly cleaned up cause false failure for other KUTTL tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jc-rh
jc-rh reviewed May 31, 2023
View reviewed changes
controllers/utils/conditions.go
InvalidPlatformImage: "InvalidPlatformImage",
MissingBlockingCR: "MissingBlockingCR",
NotAllManagedPoliciesExist: "NotAllManagedPoliciesExist",
AmbiguousManagedPoliciesNames: "AmbiguousManagedPoliciesNames",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be AmbiguousManagedPolicyNames?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial commit has it the same as in here. I did a cherry-pick without changing: 499ad67#diff-9dc0c6962ba7ab03a8510d5d877f487287f4517b59d757ddd02544008a6dcb74R46

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we'll have to do another PR in main anyways if we decide to update the name.

@jc-rh
Copy link
Member

jc-rh commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@jc-rh
Copy link
Member

jc-rh commented Jun 1, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 76f983a into openshift-kni:release-4.12 Jun 1, 2023
5 checks passed
@openshift-ci-robot
Copy link

@irinamihai: Jira Issue OCPBUGS-11769 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Differentiate between managed policies with the same name in different namespaces:

  • determine all the namespaces where we can find managed policies
  • if there is at least one managed policy name that can be found in more than one namespace fail the CGU validation and include a condition message that contains the conflicting policy names and namespaces

Cleanup KUTTL child policies (#560)

Description:

  • child policies that are not properly cleaned up cause false failure for other KUTTL tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irinamihai irinamihai deleted the main-release-4.12 branch November 16, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc-rh jc-rh jc-rh left review comments

Assignees

@jc-rh jc-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irinamihai @openshift-ci-robot @jc-rh @openshift-merge-robot