Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17480: precaching - do not use subPath for /var/lib/kubelet #632

Merged

Conversation

irinamihai
Copy link
Collaborator

Description:

@openshift-ci-robot
Copy link

@irinamihai: This pull request references Jira Issue OCPBUGS-17480, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (josclark@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Description:
- due to a bug in k8s around subPaths, we are left with volume-subpaths
  in /var/lib/kubelet - kubernetes/kubernetes#89181
- remove the use of subPath
@irinamihai
Copy link
Collaborator Author

/retest

1 similar comment
@irinamihai
Copy link
Collaborator Author

/retest

@irinamihai irinamihai requested review from sakhoury and removed request for pixelsoccupied August 9, 2023 22:10
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2023
@jc-rh jc-rh self-requested a review August 10, 2023 03:50
@jc-rh jc-rh removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@jc-rh
Copy link
Member

jc-rh commented Aug 10, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 694cd7d into openshift-kni:main Aug 10, 2023
5 checks passed
@openshift-ci-robot
Copy link

@irinamihai: Jira Issue OCPBUGS-17480: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17480 has been moved to the MODIFIED state.

In response to this:

Description:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irinamihai irinamihai deleted the remove_var_lib_subpath branch November 16, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants