Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17037: Use a more specific label for TALM pod selectors #636

Conversation

fontivan
Copy link
Contributor

@fontivan fontivan commented Aug 14, 2023

  • Add more specific labels to the TALM resources
  • This should prevent seeing resources from other operators that also use the same default label in unintended places

@openshift-ci-robot
Copy link

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

  • Use a more specific label (control-plane=talm-controller-manager) for TALM pod selections
  • This should prevent seeing resources from other operators that also use the same default label in unintended places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan fontivan force-pushed the sskeard/ocpbugs-17037-pod-selector branch from e397f9e to f78333a Compare August 14, 2023 14:36
@openshift-ci-robot
Copy link

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

  • Add more specific labels to the TALM resources
  • This should prevent seeing resources from other operators that also use the same default label in unintended places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@fontivan: This pull request references Jira Issue OCPBUGS-17037, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

  • Add more specific labels to the TALM resources
  • This should prevent seeing resources from other operators that also use the same default label in unintended places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan
Copy link
Contributor Author

fontivan commented Aug 14, 2023

With this change I can see the pod selector on the deployment has become much more specific as it includes all 3 of the labels

image
image

I can also see that multiple other deployments use the label control-plane: controller-manager however it looks like the gitops operator was the only one that was also in the same namespace as reported in the bug
image

@jc-rh
Copy link
Member

jc-rh commented Aug 14, 2023

/retest

1 similar comment
@jc-rh
Copy link
Member

jc-rh commented Aug 15, 2023

/retest

@fontivan
Copy link
Contributor Author

/test integration

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 152d2e8 into openshift-kni:main Aug 15, 2023
5 checks passed
@openshift-ci-robot
Copy link

@fontivan: Jira Issue OCPBUGS-17037: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17037 has been moved to the MODIFIED state.

In response to this:

  • Add more specific labels to the TALM resources
  • This should prevent seeing resources from other operators that also use the same default label in unintended places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan
Copy link
Contributor Author

/cherrypick release-4.13

@openshift-cherrypick-robot

@fontivan: new pull request created: #638

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fontivan
Copy link
Contributor Author

/cherrypick release-4.12

@openshift-cherrypick-robot

@fontivan: new pull request could not be created: failed to create pull request against openshift-kni/cluster-group-upgrades-operator#release-4.13 from head openshift-cherrypick-robot:cherry-pick-636-to-release-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-636-to-release-4.13."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@fontivan: new pull request created: #639

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants