OCPBUGS-17382: Fix for CGU not being autocreated #637
Conversation
fontivan
commented
Aug 14, 2023
fontivan
commented
- If you were to delete the CGU and then remove ztp-done from a node, then the CGU would previously not be auto-created again
- This fixes that behaviour so that it does not matter which operation you do first, the auto-creation should now run again regardless
- If you were to delete the CGU and then remove ztp-done from a node, then the CGU would previously not be auto-created again - This fixes that behaviour so that it does not matter which operation you do first, the auto-creation should now run again regardless
|
@fontivan: This pull request references Jira Issue OCPBUGS-17382, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@fontivan: This pull request references Jira Issue OCPBUGS-17382, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test integration |
|
Manually retested this morning on my redeployed lab and can confirm I am getting my CGU and Label back due to autocreation regardless of which one I deleted first |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jc-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@fontivan: Jira Issue OCPBUGS-17382: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-17382 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.13 |
|
@fontivan: new pull request created: #640 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.12 |
|
@fontivan: new pull request created: #641 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
