Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19723: Add PreCachingConfig to owned CRDs under csv #681

Conversation

sakhoury
Copy link
Contributor

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

@openshift-ci-robot
Copy link

@sakhoury: This pull request references Jira Issue OCPBUGS-19723, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sakhoury: This pull request references Jira Issue OCPBUGS-19723, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sakhoury
Copy link
Contributor Author

/cc @rauhersu

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

Signed-off-by: Sharat Akhoury <sakhoury@redhat.com>
@sakhoury sakhoury force-pushed the opcbugs-19723-add-resources-precachingconfig-crd branch from ac04525 to 1d9987f Compare September 28, 2023 21:25
@sakhoury
Copy link
Contributor Author

/test ci-job

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@openshift-ci-robot
Copy link

@sakhoury: This pull request references Jira Issue OCPBUGS-19723, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sakhoury: This pull request references Jira Issue OCPBUGS-19723, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudomakeinstall2
Copy link
Collaborator

this pr #682
will fix the ci.

@sudomakeinstall2
Copy link
Collaborator

/retest

@jc-rh
Copy link
Member

jc-rh commented Sep 29, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh, rauhersu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@openshift-ci-robot
Copy link

@sakhoury: This pull request references Jira Issue OCPBUGS-19723, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sakhoury: This pull request references Jira Issue OCPBUGS-19723, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1c7bec6 into openshift-kni:main Sep 29, 2023
5 checks passed
@openshift-ci-robot
Copy link

@sakhoury: Jira Issue OCPBUGS-19723: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19723 has been moved to the MODIFIED state.

In response to this:

This commit adds the PreCachingConfig CRD to the list of CRDs owned by the cluster-group-upgrades operator under the ClusterServiceVersion manifest.

/cc @jc-rh @sudomakeinstall2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sakhoury
Copy link
Contributor Author

/cherrypick release-4.14

@sakhoury sakhoury deleted the opcbugs-19723-add-resources-precachingconfig-crd branch September 29, 2023 18:00
@openshift-cherrypick-robot

@sakhoury: new pull request created: #683

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants