[release-4.14] OCPBUGS-30571: Fix for ACM Policy Generator Plugin

[edcdavid]

• This commit fixes an issue happening when using policies generated with ACM Policy Generator Plugin.
  For ConfigurationPolicy kind, the name of the object and the inner template are the same when generated with ACM Gen.
  In comparison the PGT plugin, adds "-config" to the name of the inner template. this leads to overloaded keys in the
  clusterGroupUpgrade.Status.SafeResourceNames map.

Changes:

• namespace+"/"+name key used in the clusterGroupUpgrade.Status.SafeResourceNames map
• use of namespace instead of namespace length in GetSafeResourceName
• use of utf8.RuneCountInString() instead of len to support non english characters (see policy web hook at https://github.com/stolostron/governance-policy-propagator/blob/feb9abb241954d7ce64054d7c621b423deece8cf/api/v1/policy_webhook.go#L86-L87 ).
• adding logs to display the safenames and lenghts

• Addressing Jun's comments

• Addinitonal fixes for map key

• fix kuttl test

[openshift-ci-robot]

@edcdavid: This pull request references Jira Issue OCPBUGS-29208, which is invalid:

• expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.16.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• expected Jira Issue OCPBUGS-29208 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• This commit fixes an issue happening when using policies generated with ACM Policy Generator Plugin.
  For ConfigurationPolicy kind, the name of the object and the inner template are the same when generated with ACM Gen.
  In comparison the PGT plugin, adds "-config" to the name of the inner template. this leads to overloaded keys in the
  clusterGroupUpgrade.Status.SafeResourceNames map.

Changes:

• namespace+"/"+name key used in the clusterGroupUpgrade.Status.SafeResourceNames map
• use of namespace instead of namespace length in GetSafeResourceName
• use of utf8.RuneCountInString() instead of len to support non english characters (see policy web hook at https://github.com/stolostron/governance-policy-propagator/blob/feb9abb241954d7ce64054d7c621b423deece8cf/api/v1/policy_webhook.go#L86-L87 ).
• adding logs to display the safenames and lenghts

• Addressing Jun's comments

• Addinitonal fixes for map key

• fix kuttl test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@edcdavid: This pull request references Jira Issue OCPBUGS-30571, which is invalid:

• expected Jira Issue OCPBUGS-30571 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• This commit fixes an issue happening when using policies generated with ACM Policy Generator Plugin.
  For ConfigurationPolicy kind, the name of the object and the inner template are the same when generated with ACM Gen.
  In comparison the PGT plugin, adds "-config" to the name of the inner template. this leads to overloaded keys in the
  clusterGroupUpgrade.Status.SafeResourceNames map.

Changes:

• namespace+"/"+name key used in the clusterGroupUpgrade.Status.SafeResourceNames map
• use of namespace instead of namespace length in GetSafeResourceName
• use of utf8.RuneCountInString() instead of len to support non english characters (see policy web hook at https://github.com/stolostron/governance-policy-propagator/blob/feb9abb241954d7ce64054d7c621b423deece8cf/api/v1/policy_webhook.go#L86-L87 ).
• adding logs to display the safenames and lenghts

• Addressing Jun's comments

• Addinitonal fixes for map key

• fix kuttl test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[edcdavid]

/jira refresh

[openshift-ci-robot]

@edcdavid: This pull request references Jira Issue OCPBUGS-30571, which is invalid:

• expected Jira Issue OCPBUGS-30571 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jc-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@edcdavid: Jira Issue OCPBUGS-30571: All pull requests linked via external trackers have merged:

• openshift-kni/cluster-group-upgrades-operator#757

Jira Issue OCPBUGS-30571 has been moved to the MODIFIED state.

In response to this:

• This commit fixes an issue happening when using policies generated with ACM Policy Generator Plugin.
  For ConfigurationPolicy kind, the name of the object and the inner template are the same when generated with ACM Gen.
  In comparison the PGT plugin, adds "-config" to the name of the inner template. this leads to overloaded keys in the
  clusterGroupUpgrade.Status.SafeResourceNames map.

Changes:

• namespace+"/"+name key used in the clusterGroupUpgrade.Status.SafeResourceNames map
• use of namespace instead of namespace length in GetSafeResourceName
• use of utf8.RuneCountInString() instead of len to support non english characters (see policy web hook at https://github.com/stolostron/governance-policy-propagator/blob/feb9abb241954d7ce64054d7c621b423deece8cf/api/v1/policy_webhook.go#L86-L87 ).
• adding logs to display the safenames and lenghts

• Addressing Jun's comments

• Addinitonal fixes for map key

• fix kuttl test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.