New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-8238: ztp: Remove incorrect macAddress field #1431
OCPBUGS-8238: ztp: Remove incorrect macAddress field #1431
Conversation
@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Would it be possible to delete it from cnf-features-deploy/ztp/siteconfig-generator-kustomize-plugin/testSiteConfig as well? |
The macAddress field under spec.clusters[].nodes[].nodeNetwork.config.interfaces[] is not needed. The network configuration is matched to interfaces based on the macAddress under the spec.clusters[].nodes[].nodeNetwork.interfaces[]. In addition, if the config.interfaces field is included it needs to be mac-addresses. Since it is not necessary this PR simply removes it. Signed-off-by: Ian Miller <imiller@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imiller0, nishant-parekh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@imiller0: Jira Issue OCPBUGS-8238: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8238 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@imiller0: new pull request created: #1434 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The macAddress field under
spec.clusters[].nodes[].nodeNetwork.config.interfaces[] is not needed. The network configuration is matched to interfaces based on the macAddress under the spec.clusters[].nodes[].nodeNetwork.interfaces[]. In addition, if the config.interfaces field is included it needs to be mac-addresses. Since it is not necessary this PR simply removes it.