Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-8238: ztp: Remove incorrect macAddress field #1431

Merged
merged 1 commit into from Mar 9, 2023

Conversation

imiller0
Copy link
Contributor

@imiller0 imiller0 commented Mar 9, 2023

The macAddress field under
spec.clusters[].nodes[].nodeNetwork.config.interfaces[] is not needed. The network configuration is matched to interfaces based on the macAddress under the spec.clusters[].nodes[].nodeNetwork.interfaces[]. In addition, if the config.interfaces field is included it needs to be mac-addresses. Since it is not necessary this PR simply removes it.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 9, 2023
@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The macAddress field under
spec.clusters[].nodes[].nodeNetwork.config.interfaces[] is not needed. The network configuration is matched to interfaces based on the macAddress under the spec.clusters[].nodes[].nodeNetwork.interfaces[]. In addition, if the config.interfaces field is included it needs to be mac-addresses. Since it is not necessary this PR simply removes it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@imiller0
Copy link
Contributor Author

imiller0 commented Mar 9, 2023

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imiller0
Copy link
Contributor Author

imiller0 commented Mar 9, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 9, 2023
@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@imiller0: This pull request references Jira Issue OCPBUGS-8238, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tliu2021
Copy link
Contributor

tliu2021 commented Mar 9, 2023

Would it be possible to delete it from cnf-features-deploy/ztp/siteconfig-generator-kustomize-plugin/testSiteConfig as well?

The macAddress field under
spec.clusters[].nodes[].nodeNetwork.config.interfaces[] is not needed.
The network configuration is matched to interfaces based on the
macAddress under the spec.clusters[].nodes[].nodeNetwork.interfaces[].
In addition, if the config.interfaces field is included it needs to be
mac-addresses. Since it is not necessary this PR simply removes it.

Signed-off-by: Ian Miller <imiller@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, nishant-parekh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9baa81a into openshift-kni:master Mar 9, 2023
@openshift-ci-robot
Copy link
Collaborator

@imiller0: Jira Issue OCPBUGS-8238: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8238 has been moved to the MODIFIED state.

In response to this:

The macAddress field under
spec.clusters[].nodes[].nodeNetwork.config.interfaces[] is not needed. The network configuration is matched to interfaces based on the macAddress under the spec.clusters[].nodes[].nodeNetwork.interfaces[]. In addition, if the config.interfaces field is included it needs to be mac-addresses. Since it is not necessary this PR simply removes it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imiller0
Copy link
Contributor Author

imiller0 commented Mar 9, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@imiller0: new pull request created: #1434

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants