[release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig #1495

eggfoobar · 2023-05-08T13:14:12Z

PR back ports #1441 and #1497

openshift-ci · 2023-05-08T13:14:17Z

@eggfoobar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] Backport cpu partitioning siteconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-05-08T13:14:25Z

Hi @eggfoobar. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imiller0 · 2023-05-08T13:47:55Z

/ok-to-test

add new flag for cpu partitioning mode add deprecation warning for situations where cpuset is defined for nodes Signed-off-by: ehila <ehila@redhat.com>

Signed-off-by: ehila <ehila@redhat.com>

imiller0 · 2023-05-08T21:28:03Z

/hold
pending timing of this backport relative to 4.13 release

Signed-off-by: ehila <ehila@redhat.com>

openshift-ci · 2023-05-09T14:04:56Z

@eggfoobar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] Backport cpu partitioning siteconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-05-09T16:31:10Z

@eggfoobar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] Bug OCPBUGS-13301: Backport cpu partitioning siteconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-09T16:31:12Z

@eggfoobar: This pull request references Jira Issue OCPBUGS-13301, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.13.z" instead
expected Jira Issue OCPBUGS-13301 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

PR back ports #1441 and #1497

/assign @imiller0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imiller0 · 2023-05-09T16:31:44Z

/jira refresh

openshift-ci-robot · 2023-05-09T16:31:46Z

@imiller0: This pull request references Jira Issue OCPBUGS-13301, which is invalid:

expected Jira Issue OCPBUGS-13301 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-05-09T16:34:10Z

@eggfoobar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-09T16:34:10Z

@eggfoobar: This pull request references Jira Issue OCPBUGS-13313, which is invalid:

expected Jira Issue OCPBUGS-13313 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

PR back ports #1441 and #1497

/assign @imiller0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imiller0 · 2023-05-15T21:07:11Z

/unhold
4.13 GA artifacts are built. Backport can merge for z-stream.

imiller0 · 2023-07-13T21:20:24Z

/jira refresh

openshift-ci-robot · 2023-07-13T21:20:28Z

@imiller0: This pull request references Jira Issue OCPBUGS-13313, which is invalid:

expected dependent Jira Issue OCPBUGS-13301 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ASSIGNED instead
expected dependent Jira Issue OCPBUGS-13310 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-13310 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imiller0 · 2023-08-01T13:25:23Z

Just to confirm: If the user continues to use cpuset (and not cpuPartitioningMode) in their SiteConfig the tool will continue to generate the MachineConfigs. In this case workload partitioning continues to be enabled "the old way" and there is no actual impact, correct?

eggfoobar · 2023-08-01T14:01:17Z

That's correct, because of this logic below we still get the old way for SNO and then you can go down the new path with techpreview on 4.13 for non SNO deployments. We also do have some unit tests in place to that will validate that behavior.

cnf-features-deploy/ztp/siteconfig-generator/siteConfig/siteConfigBuilder.go

Lines 424 to 444 in 8d4e1d7

    
           if clusterSpec.ClusterType == SNO { 
        
           	for node := range clusterSpec.Nodes { 
        
           		cpuSet := clusterSpec.Nodes[node].Cpuset 
        
           		role := clusterSpec.Nodes[node].Role 
        
           		if cpuSet != "" { 
        
           			k, v, err := scbuilder.getWorkloadManifest(cpuSet, role) 
        
           			if err != nil { 
        
           				errStr := fmt.Sprintf("Error could not read WorkloadManifest %s %s\n", clusterSpec.ClusterName, err) 
        
           				return dataMap, errors.New(errStr) 
        
           			} else { 
        
           				data, err := addZTPAnnotationToManifest(v.(string)) 
        
           				if err != nil { 
        
           					return dataMap, err 
        
           				} 
        
           				dataMap[k] = data 
        
           				// Exclude the workload manifest 
        
           				doNotMerge[k] = true 
        
           			} 
        
           		} 
        
           	} 
        
           }

imiller0

/lgtm

openshift-ci · 2023-08-02T12:15:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, imiller0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ztp/OWNERS~~ [imiller0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

imiller0 · 2023-08-07T17:55:20Z

/jira refresh

openshift-ci-robot · 2023-08-07T17:55:23Z

@imiller0: This pull request references Jira Issue OCPBUGS-13313, which is invalid:

expected dependent Jira Issue OCPBUGS-16409 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Jira Issue OCPBUGS-13310 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ASSIGNED instead
expected dependent Jira Issue OCPBUGS-13310 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imiller0 · 2023-08-07T17:57:29Z

/jira refresh

openshift-ci-robot · 2023-08-07T17:57:32Z

@imiller0: This pull request references Jira Issue OCPBUGS-13313, which is invalid:

expected dependent Jira Issue OCPBUGS-16409 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imiller0 · 2023-08-07T17:58:36Z

/jira refresh

openshift-ci-robot · 2023-08-07T17:58:40Z

@imiller0: This pull request references Jira Issue OCPBUGS-13313, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-13301 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-13301 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @dgonyier

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-08-07T17:58:43Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: dgonyier.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@imiller0: This pull request references Jira Issue OCPBUGS-13313, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.13.z) matches configured target version for branch (4.13.z)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

dependent bug Jira Issue OCPBUGS-13301 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))

dependent Jira Issue OCPBUGS-13301 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0

bug has dependents

Requesting review from QA contact:
/cc @dgonyier

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-07T18:23:08Z

@eggfoobar: Jira Issue OCPBUGS-13313: All pull requests linked via external trackers have merged:

openshift-kni/cnf-features-deploy#1495

Jira Issue OCPBUGS-13313 has been moved to the MODIFIED state.

In response to this:

PR back ports #1441 and #1497

/assign @imiller0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned imiller0 May 8, 2023

openshift-ci bot requested review from mmirecki and swatisehgal May 8, 2023 13:14

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2023

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2023

eggfoobar force-pushed the backport-cpu-partitioning-siteconfig branch from 6ecc7bd to 1923b89 Compare May 8, 2023 14:03

eggfoobar added 3 commits May 8, 2023 11:46

ztp: add support for cpu partitioning on site config

a34e653

add new flag for cpu partitioning mode add deprecation warning for situations where cpuset is defined for nodes Signed-off-by: ehila <ehila@redhat.com>

ztp: added unit tests and updated deprecation warning message

ba39633

Signed-off-by: ehila <ehila@redhat.com>

ztp: fixed unit tests

01d845d

Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the backport-cpu-partitioning-siteconfig branch from 1923b89 to 01d845d Compare May 8, 2023 15:46

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2023

ztp: fix annotation name

8d4e1d7

Signed-off-by: ehila <ehila@redhat.com>

imiller0 changed the title ~~[release-4.13] Backport cpu partitioning siteconfig~~ [release-4.13] Bug OCPBUGS-13301: Backport cpu partitioning siteconfig May 9, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 9, 2023

imiller0 changed the title ~~[release-4.13] Bug OCPBUGS-13301: Backport cpu partitioning siteconfig~~ [release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig May 9, 2023

openshift-ci-robot mentioned this pull request May 11, 2023

feat: Bug OCPBUGS-13301: add support for cpu partitioning on site config #1441

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023

imiller0 reviewed Aug 2, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023

imiller0 approved these changes Aug 2, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 7, 2023

openshift-merge-robot merged commit bbd0904 into openshift-kni:release-4.13 Aug 7, 2023
4 checks passed

openshift-ci-robot mentioned this pull request Aug 17, 2023

OCPBUGS-13313: fix: error in messaging for cpu partitioning #1610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig #1495

[release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig #1495

eggfoobar commented May 8, 2023 •

edited

openshift-ci bot commented May 8, 2023

openshift-ci bot commented May 8, 2023

imiller0 commented May 8, 2023

imiller0 commented May 8, 2023

openshift-ci bot commented May 9, 2023

openshift-ci bot commented May 9, 2023

openshift-ci-robot commented May 9, 2023

imiller0 commented May 9, 2023

openshift-ci-robot commented May 9, 2023

openshift-ci bot commented May 9, 2023

openshift-ci-robot commented May 9, 2023

imiller0 commented May 15, 2023

imiller0 commented Jul 13, 2023

openshift-ci-robot commented Jul 13, 2023

imiller0 commented Aug 1, 2023

eggfoobar commented Aug 1, 2023

imiller0 left a comment

openshift-ci bot commented Aug 2, 2023

imiller0 commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

imiller0 commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

imiller0 commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

openshift-ci bot commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

[release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig #1495

[release-4.13] Bug OCPBUGS-13313: Backport cpu partitioning siteconfig #1495

Conversation

eggfoobar commented May 8, 2023 • edited

openshift-ci bot commented May 8, 2023

openshift-ci bot commented May 8, 2023

imiller0 commented May 8, 2023

imiller0 commented May 8, 2023

openshift-ci bot commented May 9, 2023

openshift-ci bot commented May 9, 2023

openshift-ci-robot commented May 9, 2023

imiller0 commented May 9, 2023

openshift-ci-robot commented May 9, 2023

openshift-ci bot commented May 9, 2023

openshift-ci-robot commented May 9, 2023

imiller0 commented May 15, 2023

imiller0 commented Jul 13, 2023

openshift-ci-robot commented Jul 13, 2023

imiller0 commented Aug 1, 2023

eggfoobar commented Aug 1, 2023

imiller0 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Aug 2, 2023

imiller0 commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

imiller0 commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

imiller0 commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

openshift-ci bot commented Aug 7, 2023

openshift-ci-robot commented Aug 7, 2023

eggfoobar commented May 8, 2023 •

edited