Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13070: set gitOps operator channel #1504

Merged
merged 1 commit into from
May 26, 2023
Merged

OCPBUGS-13070: set gitOps operator channel #1504

merged 1 commit into from
May 26, 2023

Conversation

serngawy
Copy link
Contributor

No description provided.

@serngawy
ztp: set gitOps operator channel
1a99fae 
Signed-off-by: melserngawy <melserng@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2023
@openshift-ci openshift-ci bot requested review from sakhoury and Tal-or May 15, 2023 16:32
@openshift-ci-robot
Copy link
Collaborator

@serngawy: This pull request references Jira Issue OCPBUGS-13070, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
yliu127
yliu127 reviewed May 15, 2023
View reviewed changes
ztp/gitops-subscriptions/argocd/deployment/openshift-gitops-operator.yaml
@@ -9,9 +9,8 @@ metadata:
name: openshift-gitops-operator
namespace: openshift-operators
spec:
channel: stable
channel: gitops-1.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we consider using "latest" channel instead of versioned channel?

Copy link
Contributor Author

@serngawy serngawy May 15, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the idea to stay with latest-1 version and update the channel with every ztp release.

imiller0
imiller0 reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@serngawy
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@serngawy: This pull request references Jira Issue OCPBUGS-13070, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serngawy
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 26, 2023
@openshift-ci-robot
Copy link
Collaborator

@serngawy: This pull request references Jira Issue OCPBUGS-13070, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@serngawy: This pull request references Jira Issue OCPBUGS-13070, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit efe8c5d into openshift-kni:master May 26, 2023
4 checks passed
@openshift-ci-robot
Copy link
Collaborator

@serngawy: Jira Issue OCPBUGS-13070: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13070 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 imiller0 left review comments

@yliu127 yliu127 yliu127 left review comments

@sakhoury sakhoury Awaiting requested review from sakhoury

@Tal-or Tal-or Awaiting requested review from Tal-or

Assignees

@imiller0 imiller0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@serngawy @openshift-ci-robot @imiller0 @yliu127 @openshift-merge-robot