-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-9413: ztp: remove the deprecated curation section from ClusterLogging CR #1514
OCPBUGS-9413: ztp: remove the deprecated curation section from ClusterLogging CR #1514
Conversation
The curation section is now completely deprecated in cluster logging 5.7 which can be safely cleaned up.
@Missxiaoguo: This pull request references Jira Issue OCPBUGS-9413, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @imiller0 |
From your comment it sounds like it is also safe to leave this configuration in place on any existing clusters. Is that right? If so this lgtm |
Yes, exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imiller0, Missxiaoguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@Missxiaoguo: This pull request references Jira Issue OCPBUGS-9413, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ci/prow/e2e-gcp-ovn |
@Missxiaoguo: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-ovn |
1 similar comment
/test e2e-gcp-ovn |
/override ci/prow/e2e-gcp-ovn |
@lack: Overrode contexts on behalf of lack: ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Missxiaoguo: Jira Issue OCPBUGS-9413: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-9413 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The curation section is now completely deprecated in cluster logging 5.7 which can be safely cleaned up. Removing it shouldn't have any impact on users who currently have it configured.