Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-9413: ztp: remove the deprecated curation section from ClusterLogging CR #1514

Merged

Conversation

Missxiaoguo
Copy link
Contributor

The curation section is now completely deprecated in cluster logging 5.7 which can be safely cleaned up. Removing it shouldn't have any impact on users who currently have it configured.

The curation section is now completely deprecated in cluster logging
5.7 which can be safely cleaned up.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 23, 2023
@openshift-ci-robot
Copy link
Collaborator

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-9413, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The curation section is now completely deprecated in cluster logging 5.7 which can be safely cleaned up. Removing it shouldn't have any impact on users who currently have it configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 23, 2023
@openshift-ci openshift-ci bot requested review from ijolliffe and sakhoury May 23, 2023 19:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@Missxiaoguo
Copy link
Contributor Author

/cc @imiller0

@openshift-ci openshift-ci bot requested a review from imiller0 May 23, 2023 20:11
@imiller0
Copy link
Contributor

From your comment it sounds like it is also safe to leave this configuration in place on any existing clusters. Is that right? If so this lgtm

@Missxiaoguo
Copy link
Contributor Author

From your comment it sounds like it is also safe to leave this configuration in place on any existing clusters. Is that right? If so this lgtm

Yes, exactly.

Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, Missxiaoguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Missxiaoguo
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 24, 2023
@openshift-ci-robot
Copy link
Collaborator

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-9413, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-9413, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Missxiaoguo
Copy link
Contributor Author

/test ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@Missxiaoguo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci
  • /test e2e-gcp-ovn
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ran-profile

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Missxiaoguo
Copy link
Contributor Author

/test e2e-gcp-ovn

1 similar comment
@Missxiaoguo
Copy link
Contributor Author

/test e2e-gcp-ovn

@lack
Copy link
Member

lack commented Jun 5, 2023

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@lack: Overrode contexts on behalf of lack: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d48cabe into openshift-kni:master Jun 5, 2023
5 checks passed
@openshift-ci-robot
Copy link
Collaborator

@Missxiaoguo: Jira Issue OCPBUGS-9413: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-9413 has been moved to the MODIFIED state.

In response to this:

The curation section is now completely deprecated in cluster logging 5.7 which can be safely cleaned up. Removing it shouldn't have any impact on users who currently have it configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants