-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-13805: ztp: Update the reference configuration for LocalVolume #1521
OCPBUGS-13805: ztp: Update the reference configuration for LocalVolume #1521
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Missxiaoguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Missxiaoguo: This pull request references Jira Issue OCPBUGS-13805, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@Missxiaoguo: This pull request references Jira Issue OCPBUGS-13805, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
looking at related tickets...should we also update |
Yeah, I think so after that feature is complete. I see the persistent naming support in agent installer has not been fully completed yet. |
9317a77
to
5ce8237
Compare
/assign @imiller0 |
5ce8237
to
ec3ae8e
Compare
/cc @lack |
/cc @imiller0 |
Update the StorageLV source-cr and the reference example to use persistent device names.
ec3ae8e
to
793866e
Compare
/lgtm |
3a3d8e1
into
openshift-kni:master
@Missxiaoguo: Jira Issue OCPBUGS-13805: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13805 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the StorageLV source-cr and the reference example to use persistent device names.