Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13805: ztp: Update the reference configuration for LocalVolume #1521

Merged

Conversation

Missxiaoguo
Copy link
Contributor

Update the StorageLV source-cr and the reference example to use persistent device names.

@openshift-ci openshift-ci bot requested review from marioferh and yuvalk May 29, 2023 17:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Missxiaoguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2023
@Missxiaoguo Missxiaoguo changed the title ztp: Update the reference configuration for LocalVolume OCPBUGS-13805: ztp: Update the reference configuration for LocalVolume May 29, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2023
@openshift-ci-robot
Copy link
Collaborator

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-13805, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update the StorageLV source-cr and the reference example to use persistent device names.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 29, 2023
@Missxiaoguo
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 29, 2023
@openshift-ci-robot
Copy link
Collaborator

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-13805, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-13805, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixelsoccupied
Copy link
Contributor

looking at related tickets...should we also update rootDeviceHints in SC to use persistent naming?

@Missxiaoguo
Copy link
Contributor Author

looking at related tickets...should we also update rootDeviceHints in SC to use persistent naming?

Yeah, I think so after that feature is complete. I see the persistent naming support in agent installer has not been fully completed yet.

@Missxiaoguo Missxiaoguo force-pushed the OCPBUGS-13805 branch 2 times, most recently from 9317a77 to 5ce8237 Compare June 1, 2023 14:41
@Missxiaoguo
Copy link
Contributor Author

/assign @imiller0

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2023
@Missxiaoguo
Copy link
Contributor Author

/cc @lack

@openshift-ci openshift-ci bot requested a review from lack July 26, 2023 14:31
@Missxiaoguo
Copy link
Contributor Author

/cc @imiller0

@openshift-ci openshift-ci bot requested a review from imiller0 July 26, 2023 14:32
Update the StorageLV source-cr and the reference example to use
persistent device names.
@lack
Copy link
Member

lack commented Jul 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3a3d8e1 into openshift-kni:master Jul 27, 2023
3 of 4 checks passed
@openshift-ci-robot
Copy link
Collaborator

@Missxiaoguo: Jira Issue OCPBUGS-13805: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13805 has been moved to the MODIFIED state.

In response to this:

Update the StorageLV source-cr and the reference example to use persistent device names.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants