Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-3513: use manifestsConfigMapRefs #1526

Merged
merged 1 commit into from
Jun 21, 2023
Merged

OCPBUGS-3513: use manifestsConfigMapRefs #1526

merged 1 commit into from
Jun 21, 2023

Conversation

serngawy
Copy link
Contributor

@serngawy serngawy commented Jun 6, 2023

No description provided.

@serngawy
ztp: fix bug OCPBUGS-3513
fb043f0 
Signed-off-by: melserngawy <melserng@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2023
@openshift-ci-robot
Copy link
Collaborator

@serngawy: This pull request references Jira Issue OCPBUGS-3513, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from MarSik and simon3z June 6, 2023 15:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@serngawy
Copy link
Contributor Author

serngawy commented Jun 6, 2023

/retest-required

@serngawy
Copy link
Contributor Author

serngawy commented Jun 6, 2023

/test images

@serngawy
Copy link
Contributor Author

serngawy commented Jun 6, 2023

/test e2e-aws-ran-profile

@serngawy
Copy link
Contributor Author

serngawy commented Jun 8, 2023 •
edited

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@serngawy: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test ci
  • /test e2e-gcp-ovn
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ran-profile

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kni-cnf-features-deploy-master-ci
  • pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ran-profile
  • pull-ci-openshift-kni-cnf-features-deploy-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serngawy
Copy link
Contributor Author

/test images

@serngawy
Copy link
Contributor Author

/test e2e-aws-ran-profile

@serngawy
Copy link
Contributor Author

/cc @lack

@openshift-ci openshift-ci bot requested a review from lack June 12, 2023 14:44
@serngawy
Copy link
Contributor Author

/cc @sabbir-47

@openshift-ci openshift-ci bot requested a review from sabbir-47 June 12, 2023 14:45
@serngawy
Copy link
Contributor Author

/test-required

@serngawy
Copy link
Contributor Author

/test e2e-aws-ran-profile

@serngawy
Copy link
Contributor Author

/retest-required

@lack
Copy link
Member

lack commented Jun 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@lack
Copy link
Member

lack commented Jun 16, 2023

Is there a specific version of ACM required for this to work? Should we update the docs to say that? Should we mention that in the commit message?

@serngawy
Copy link
Contributor Author

Is there a specific version of ACM required for this to work? Should we update the docs to say that? Should we mention that in the commit message?

It is available starting from v2.3 I guess they cherry-pick it to old releases. I think we are good, Do you want to mentioned that in the PR desc or doc ?

imiller0
imiller0 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serngawy
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 21, 2023
@openshift-ci-robot
Copy link
Collaborator

@serngawy: This pull request references Jira Issue OCPBUGS-3513, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@serngawy: This pull request references Jira Issue OCPBUGS-3513, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serngawy
Copy link
Contributor Author

/test e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023 •
edited

@serngawy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile fb043f0 link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lack
Copy link
Member

lack commented Jun 21, 2023

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@lack: Overrode contexts on behalf of lack: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lack
Copy link
Member

lack commented Jun 21, 2023

/test ci/prow/e2e-aws-ran-profile

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@lack: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci
  • /test e2e-gcp-ovn
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ran-profile

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kni-cnf-features-deploy-master-ci
  • pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ran-profile
  • pull-ci-openshift-kni-cnf-features-deploy-master-images

In response to this:

/test ci/prow/e2e-aws-ran-profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lack
Copy link
Member

lack commented Jun 21, 2023

/test e2e-aws-ran-profile

@openshift-merge-robot openshift-merge-robot merged commit 838f79c into openshift-kni:master Jun 21, 2023
4 of 5 checks passed
@openshift-ci-robot
Copy link
Collaborator

@serngawy: Jira Issue OCPBUGS-3513: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3513 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixelsoccupied pixelsoccupied mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 imiller0 approved these changes

@MarSik MarSik Awaiting requested review from MarSik

@simon3z simon3z Awaiting requested review from simon3z

@lack lack Awaiting requested review from lack

@sabbir-47 sabbir-47 Awaiting requested review from sabbir-47

Assignees

@lack lack

@imiller0 imiller0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@serngawy @openshift-ci-robot @lack @imiller0 @openshift-merge-robot