Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13634: ztp: remove accelerated container startup #1561

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

tliu2021
Copy link
Contributor

A known issue, tracked by OCPBUGS-15102 in OCP 4.13 and 4.14, could lead to the CPU affinities not resetting to unrestricted during startup. Consequently, the accelerated startup script fails to deliver significant improvements in boot time.

Furthermore, it was observed that the accelerated startup script did not yield substantial improvements in boot time in OCP 4.12. Therefore, it might be necessary to explore alternative approaches instead of relying solely on setting CPU affinities to unrestricted cores.

This update addresses the issue by removing the MC that contains the accelerated startup script and services. Moving forward, once the OCPBUGS-15102 is resolved, a unified accelerated startup method will be developed to cater to all cluster topologies.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci openshift-ci bot requested review from ijolliffe and Tal-or July 13, 2023 15:54
@openshift-ci-robot
Copy link
Collaborator

@tliu2021: This pull request references Jira Issue OCPBUGS-13634, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

A known issue, tracked by OCPBUGS-15102 in OCP 4.13 and 4.14, could lead to the CPU affinities not resetting to unrestricted during startup. Consequently, the accelerated startup script fails to deliver significant improvements in boot time.

Furthermore, it was observed that the accelerated startup script did not yield substantial improvements in boot time in OCP 4.12. Therefore, it might be necessary to explore alternative approaches instead of relying solely on setting CPU affinities to unrestricted cores.

This update addresses the issue by removing the MC that contains the accelerated startup script and services. Moving forward, once the OCPBUGS-15102 is resolved, a unified accelerated startup method will be developed to cater to all cluster topologies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tliu2021
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@tliu2021: This pull request references Jira Issue OCPBUGS-13634, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tliu2021
Copy link
Contributor Author

/test ci

@tliu2021
Copy link
Contributor Author

/test ci

@tliu2021
Copy link
Contributor Author

/cc @lack @imiller0

@openshift-ci openshift-ci bot requested review from imiller0 and lack July 17, 2023 14:36
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, tliu2021

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
A known issue, tracked by OCPBUGS-15102 in OCP 4.13 and 4.14, could lead to the
CPU affinities not resetting to unrestricted during startup. Consequently,
the accelerated startup script fails to deliver significant improvements in
boot time.

Furthermore,it was observed that the accelerated startup script did not yield
substantial improvements in boot time in OCP 4.12. Therefore, it might be
necessary to explore alternative approaches instead of relying solely on
setting CPU affinities to unrestricted cores.

This update addresses the issue by removing the MC that contains the accelerated
startup script and services. Moving forward, once the OCPBUGS-15102 is resolved,
a unified accelerated startup method will be developed to cater to all cluster
topologies.

Signed-off-by: Tao Liu <tali@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@imiller0
Copy link
Contributor

/retest

@imiller0
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-13634, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imiller0
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 18, 2023
@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-13634, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@imiller0: This pull request references Jira Issue OCPBUGS-13634, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imiller0
Copy link
Contributor

/retest

@tliu2021
Copy link
Contributor Author

/test images

1 similar comment
@tliu2021
Copy link
Contributor Author

/test images

@openshift-merge-robot openshift-merge-robot merged commit 39250f0 into openshift-kni:master Jul 18, 2023
4 checks passed
@openshift-ci-robot
Copy link
Collaborator

@tliu2021: Jira Issue OCPBUGS-13634: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13634 has been moved to the MODIFIED state.

In response to this:

A known issue, tracked by OCPBUGS-15102 in OCP 4.13 and 4.14, could lead to the CPU affinities not resetting to unrestricted during startup. Consequently, the accelerated startup script fails to deliver significant improvements in boot time.

Furthermore, it was observed that the accelerated startup script did not yield substantial improvements in boot time in OCP 4.12. Therefore, it might be necessary to explore alternative approaches instead of relying solely on setting CPU affinities to unrestricted cores.

This update addresses the issue by removing the MC that contains the accelerated startup script and services. Moving forward, once the OCPBUGS-15102 is resolved, a unified accelerated startup method will be developed to cater to all cluster topologies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants