Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17699: Update WPC GM config #1616

Merged
merged 1 commit into from
Aug 28, 2023
Merged

OCPBUGS-17699: Update WPC GM config #1616

merged 1 commit into from
Aug 28, 2023

Conversation

josephdrichard
Copy link
Contributor

Pins should be configured in their entirety

Add required changes to ubxtool commands

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 24, 2023
@openshift-ci-robot
Copy link
Collaborator

@josephdrichard: This pull request references Jira Issue OCPBUGS-17699, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Pins should be configured in their entirety

Add required changes to ubxtool commands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from sakhoury and yuvalk August 24, 2023 06:12
@josephdrichard
Copy link
Contributor Author

/hold
I want to do more testing before merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
imiller0
imiller0 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2023
@josephdrichard
ztp: Update WPC GM config
7a6fa2f 
Pins should be configured in their entirety

Add required changes to ubxtool commands
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@josephdrichard
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2023
imiller0
imiller0 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ac5e2b6 into openshift-kni:master Aug 28, 2023
4 checks passed
@openshift-ci-robot
Copy link
Collaborator

@josephdrichard: Jira Issue OCPBUGS-17699: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17699 has been moved to the MODIFIED state.

In response to this:

Pins should be configured in their entirety

Add required changes to ubxtool commands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yliu127
yliu127 reviewed Aug 28, 2023
View reviewed changes
ztp/source-crs/PtpConfigGmWpc.yaml
"U.FL1": "0 1"
"SMA2": "0 2"
"SMA1": "0 1"
pins: $e810_pins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does user need to specify here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliu127 yliu127 yliu127 left review comments

@imiller0 imiller0 imiller0 approved these changes

@sakhoury sakhoury Awaiting requested review from sakhoury

@yuvalk yuvalk Awaiting requested review from yuvalk

Assignees

@imiller0 imiller0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josephdrichard @openshift-ci-robot @imiller0 @yliu127 @openshift-merge-robot