ocpbugs-26931: Fix wrong cast #1769
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@daosman: This pull request references ocpbugs-26931 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| if reflect.ValueOf(item).Kind() == reflect.String { | ||
| sliceValues = append(sliceValues, item) | ||
| } else { |
There was a problem hiding this comment.
If the user has, in their template, a list which includes templated values, will this fail to replace the value, ie:
somelist:
- {{ .Node.somefield }}
There was a problem hiding this comment.
Templates does not seem to work, if you include it in the over-rinding CR
There was a problem hiding this comment.
For list item template it needs to go through same check as here. Not sure if it is a valid case usually template used to set specific field not an item in a list .
|
@daosman: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daosman, imiller0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 008716b
into
openshift-kni:master
|
/jira refresh |
|
/cherrypick release-4.15 |
|
@daosman: new pull request created: #1781 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.