Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32756: Add documentation to explain how to select the multicluster-operators-subscription image #1890

Merged

Conversation

edcdavid
Copy link
Contributor

This is to add a note about using the reference argocd-openshift-gitops-patch.json ( link) in disconnected environments where the image urls contained in the file may need to be adpated.

@edcdavid
Copy link
Contributor Author

/cc @imiller0

@openshift-ci openshift-ci bot requested a review from imiller0 April 29, 2024 22:03
@edcdavid edcdavid force-pushed the use-digest-for-mce branch 2 times, most recently from 01a18df to 9020afe Compare April 30, 2024 16:46
@edcdavid edcdavid changed the title ztp: Add Argo CD patch note for disconnected environment OCPBUGS-32756: Add documentation to explain how to select the multicluster-operators-subscription image Apr 30, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link
Collaborator

@edcdavid: This pull request references Jira Issue OCPBUGS-32756, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is to add a note about using the reference argocd-openshift-gitops-patch.json ( link) in disconnected environments where the image urls contained in the file may need to be adpated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@edcdavid
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 30, 2024
@openshift-ci-robot
Copy link
Collaborator

@edcdavid: This pull request references Jira Issue OCPBUGS-32756, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@edcdavid: This pull request references Jira Issue OCPBUGS-32756, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edcdavid
Copy link
Contributor Author

//cc @irinamihai @sabbir-47

@edcdavid
Copy link
Contributor Author

/cc @irinamihai @sabbir-47

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@edcdavid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile bdd9ebb link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irinamihai
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@irinamihai
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edcdavid, irinamihai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c9e3375 into openshift-kni:master May 6, 2024
5 of 6 checks passed
@openshift-ci-robot
Copy link
Collaborator

@edcdavid: Jira Issue OCPBUGS-32756: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32756 has been moved to the MODIFIED state.

In response to this:

This is to add a note about using the reference argocd-openshift-gitops-patch.json ( link) in disconnected environments where the image urls contained in the file may need to be adpated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants