Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1999862: ztp: Ensure the tuned performance-patch matches the PAO policy name #674

Merged
merged 1 commit into from Sep 1, 2021

Conversation

lack
Copy link
Member

@lack lack commented Aug 31, 2021

When PAO generates a tuned profile, it takes the associated PAO policy
object name and prepends openshift-node-performance-. This means that
because our examples have a PAO policy named
openshift-node-performance-profile the tuned performance patch needs
to refer to a tuned policy named
openshift-node-performance-openshift-node-performance-profile

Signed-off-by: Jim Ramsay jramsay@redhat.com

When PAO generates a tuned profile, it takes the associated PAO policy
object name and prepends `openshift-node-performance-`.  This means that
because our examples have a PAO policy named
`openshift-node-performance-profile` the tuned performance patch needs
to refer to a tuned policy named
`openshift-node-performance-openshift-node-performance-profile`

Signed-off-by: Jim Ramsay <jramsay@redhat.com>
@lack
Copy link
Member Author

lack commented Aug 31, 2021

/cc @imiller0 @browsell

@imiller0
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@lack lack changed the title ztp: Ensure the tuned performance-patch matches the PAO policy name ztp: Ensure the tuned performance-patch matches the PAO policy name [bug 1999862] Aug 31, 2021
@lack
Copy link
Member Author

lack commented Aug 31, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@lack: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lack lack changed the title ztp: Ensure the tuned performance-patch matches the PAO policy name [bug 1999862] bug 1999862: ztp: Ensure the tuned performance-patch matches the PAO policy name Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@lack: This pull request references Bugzilla bug 1999862, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1999862: ztp: Ensure the tuned performance-patch matches the PAO policy name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 31, 2021
@lack
Copy link
Member Author

lack commented Aug 31, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@lack: This pull request references Bugzilla bug 1999862, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 31, 2021
@lack
Copy link
Member Author

lack commented Sep 1, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 920bfc4 into openshift-kni:master Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@lack: All pull requests linked via external trackers have merged:

Bugzilla bug 1999862 has been moved to the MODIFIED state.

In response to this:

bug 1999862: ztp: Ensure the tuned performance-patch matches the PAO policy name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants