Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add velero pkg and backup resource #291

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

trewest
Copy link
Collaborator

@trewest trewest commented Mar 25, 2024

Add velero api client along with Backup resource and tests

@trewest
Copy link
Collaborator Author

trewest commented Mar 25, 2024

/cc @achuzhoy

pkg/velero/backup.go Outdated Show resolved Hide resolved
pkg/velero/backup.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Ignore my initial comment 👍 The interfaces look good.

Copy link
Collaborator

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments.

pkg/velero/backup.go Show resolved Hide resolved
pkg/velero/backup.go Show resolved Hide resolved
pkg/velero/backup.go Show resolved Hide resolved
@trewest trewest force-pushed the add-velero-pkg branch 3 times, most recently from 767883d to 6d57e33 Compare March 26, 2024 18:37
pkg/velero/backup.go Outdated Show resolved Hide resolved
@achuzhoy
Copy link
Collaborator

just one comment

@achuzhoy
Copy link
Collaborator

/lgtm

@trewest trewest merged commit 8f863fc into openshift-kni:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants