ocm: add klusterlet addon config and unit tests #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
kononovn
reviewed
Jun 17, 2024
kononovn
requested changes
Jun 17, 2024
|
@kononovn Thanks for your review, I've updated the PR accordingly |
kononovn
reviewed
Jun 18, 2024
|
@klaskosk Shouldn't this be in the ocm pkg? |
|
@trewest I'm not too familiar with what counts as OCM or not, but if you think it would be better as part of OCM I can move it |
@klaskosk yeah I typically try to group resources by group as much as I can If it isn't too much trouble, let's move it into the ocm pkg |
klaskosk
force-pushed
the
kac-package
branch
2 times, most recently
from
449244b
to
c3b8c36
Compare
klaskosk
changed the title
|
@trewest Ah, thanks for the explanation. I've updated the PR to move it to the ocm package |
trewest
reviewed
Jun 18, 2024
pkg/ocm/kac.go
Outdated
| // Object of the KlusterletAddonConfig as it is on the cluster. | ||
| Object *kacv1.KlusterletAddonConfig | ||
| // apiClient used to interact with the cluster. | ||
| apiClient *clients.Settings |
There was a problem hiding this comment.
I think this should be runtimeclient.Client
trewest
requested changes
Jun 18, 2024
Adds the KlusterletAddonConfig to the existing ocm package along with unit tests for the new resource.
trewest
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the KlusterletAddonConfig to the existing ocm package along with unit tests for the new resource.