Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29483: Ensure initMonitorTimeoutSeconds positive values only #360

Merged

Conversation

leo8a
Copy link
Collaborator

@leo8a leo8a commented Feb 27, 2024

If the user provides a negative value for initMonitorTimeoutSeconds, it will be rejected when validating the IBU spec.

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

@openshift-ci-robot
Copy link

@leo8a: This pull request references Jira Issue OCPBUGS-29483, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the user provides a value <= 0 for initMonitorTimeoutSeconds, it will be rejected when validating the IBU spec.

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leo8a
Copy link
Collaborator Author

leo8a commented Feb 27, 2024

/jira refresh

@openshift-ci-robot
Copy link

@leo8a: This pull request references Jira Issue OCPBUGS-29483, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yliu127 February 27, 2024 14:38
@donpenney
Copy link
Collaborator

Please leave 0 as "use default".

@leo8a leo8a force-pushed the fix-initMonitorTimeoutSeconds branch 2 times, most recently from 309b74c to 3ea1c13 Compare February 27, 2024 15:25
@openshift-ci-robot
Copy link

@leo8a: This pull request references Jira Issue OCPBUGS-29483, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

If the user provides a negative value for initMonitorTimeoutSeconds, it will be rejected when validating the IBU spec.

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

If the user provides a value < 0 for initMonitorTimeoutSeconds, it will be rejected when validating the IBU spec.

Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
@leo8a leo8a force-pushed the fix-initMonitorTimeoutSeconds branch from 3ea1c13 to a483c0c Compare February 27, 2024 15:39
@jc-rh
Copy link
Member

jc-rh commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@browsell
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ea2fb36 into openshift-kni:main Feb 28, 2024
5 checks passed
@openshift-ci-robot
Copy link

@leo8a: Jira Issue OCPBUGS-29483: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29483 has been moved to the MODIFIED state.

In response to this:

If the user provides a negative value for initMonitorTimeoutSeconds, it will be rejected when validating the IBU spec.

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leo8a leo8a deleted the fix-initMonitorTimeoutSeconds branch February 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants