Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33012: [IBU] Add presence check for backup label in patchObj #470

Merged
merged 2 commits into from
May 5, 2024

Conversation

leo8a
Copy link
Collaborator

@leo8a leo8a commented Apr 30, 2024

Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exist.

/cc @donpenney @browsell @Missxiaoguo

@openshift-ci-robot
Copy link

@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adds an existence check that searches for a label (e.g., <lca. openshift. io/backup-name>) before trying to remove it from objects defined in Backup CRs.

/cc @donpenney @browsell @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leo8a
Copy link
Collaborator Author

leo8a commented Apr 30, 2024

/jira refresh

@openshift-ci-robot
Copy link

@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leo8a
Copy link
Collaborator Author

leo8a commented Apr 30, 2024

/test ibu-e2e-flow

 Error: An rpm exception occurred: package not installed 

internal/backuprestore/backup.go Outdated Show resolved Hide resolved
internal/backuprestore/backup.go Show resolved Hide resolved
@leo8a leo8a added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
leo8a added 2 commits May 2, 2024 17:17
Grouped checks under their corresponding "for" loop structures, in this way we iterate just one time over the list of backup CRs.

Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exists. 

Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
@openshift-ci-robot
Copy link

@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exist.

/cc @donpenney @browsell @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 2, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mpmaruthu

In response to this:

Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exist.

/cc @donpenney @browsell @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leo8a leo8a removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
Copy link
Contributor

@Missxiaoguo Missxiaoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@leo8a
Copy link
Collaborator Author

leo8a commented May 3, 2024

/test ibu-e2e-flow

 Error: An rpm exception occurred: package not installed 

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@leo8a: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 89f7c7d link false /test ibu-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@browsell
Copy link
Collaborator

browsell commented May 5, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e07e211 into openshift-kni:main May 5, 2024
6 of 7 checks passed
@openshift-ci-robot
Copy link

@leo8a: Jira Issue OCPBUGS-33012: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33012 has been moved to the MODIFIED state.

In response to this:

Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exist.

/cc @donpenney @browsell @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leo8a leo8a deleted the add-patchObj-check branch May 6, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants