-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33012: [IBU] Add presence check for backup label in patchObj #470
OCPBUGS-33012: [IBU] Add presence check for backup label in patchObj #470
Conversation
@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ibu-e2e-flow
|
Grouped checks under their corresponding "for" loop structures, in this way we iterate just one time over the list of backup CRs. Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exists. Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
@leo8a: This pull request references Jira Issue OCPBUGS-33012, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu. Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test ibu-e2e-flow
|
@leo8a: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: browsell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e07e211
into
openshift-kni:main
@leo8a: Jira Issue OCPBUGS-33012: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33012 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Adds an error check for when the backup label is not found or any other temporary API issues. This aims to reduce the noise provoked when the label is tried to be removed and it doesn't exist.
/cc @donpenney @browsell @Missxiaoguo