-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-32495: prep stage doc updates and unify logs and naming #517
OCPBUGS-32495: prep stage doc updates and unify logs and naming #517
Conversation
/hold |
9d6981d
to
c68e715
Compare
c68e715
to
e43919c
Compare
@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32495, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
0814dd6
to
e981f49
Compare
c0567e8
to
c0135ff
Compare
@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32495, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/unhold |
6671fad
to
e670cc6
Compare
/hold |
e670cc6
to
83398af
Compare
@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32495, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
83398af
to
9b9eec7
Compare
9b9eec7
to
2c98d56
Compare
/unhold |
/lgtm |
the extramanifest clean up/nit covered in #521. wdyt about getting this PR in before 521? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: donpenney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/integration |
@donpenney: Overrode contexts on behalf of donpenney: ci/prow/integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pixelsoccupied: Jira Issue OCPBUGS-32495 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Background / Context
This PR finalizes the work related Prep stage resiliency with docs + log messages + uniform naming convention
Things to note:
lca-prep-precache
. This should indicate that the job is fromPrep
stage. This also means previously appended resource names (job
orcm
) are also dropped as they are redundant and they are both using the same name.Updated extra-manifest warning annotation key to follow convention.<subsystem>.lca.openshift.io/warn-<name of the warning>
Addressed nits from prev PR(Strikethrough will be addressed in another PR)
Ref:
#476
#498
/cc @donpenney @Missxiaoguo