Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32495: prep stage doc updates and unify logs and naming #517

Merged
merged 1 commit into from
May 21, 2024

Conversation

pixelsoccupied
Copy link
Contributor

@pixelsoccupied pixelsoccupied commented May 15, 2024

Background / Context

This PR finalizes the work related Prep stage resiliency with docs + log messages + uniform naming convention

Things to note:

  • Cleaned up existing docs to reflect the updates better and helpful commands to get logs.
  • Removed precache plugin md file as they were mostly dev focused (all which are already in .go file) and/or outdated.
  • Streamlined logs and status messages to include job metadata
  • Updated precache resource name to be simply lca-prep-precache. This should indicate that the job is from Prep stage. This also means previously appended resource names (job or cm) are also dropped as they are redundant and they are both using the same name.
  • Updated extra-manifest warning annotation key to follow convention. <subsystem>.lca.openshift.io/warn-<name of the warning>
  • Addressed nits from prev PR
    (Strikethrough will be addressed in another PR)

Ref:
#476
#498

/cc @donpenney @Missxiaoguo

@pixelsoccupied
Copy link
Contributor Author

/hold
until #498

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@pixelsoccupied pixelsoccupied changed the title prep stage doc updates and unify logs and naming OCPBUGS-32495: prep stage doc updates and unify logs and naming May 16, 2024
@openshift-ci-robot
Copy link

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32495, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Background / Context

This PR finalizes the work related Prep stage resiliency with docs + log messages + uniform naming convention

Removed precache plugin md file as they were mostly focused on dev (all which are already in .go file) and/or outdated.

#476
#498

/cc @donpenney @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32495, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Background / Context

This PR finalizes the work related Prep stage resiliency with docs + log messages + uniform naming convention

Things to note:

  • Cleaned up existing docs to reflect the updates better and helpful commands to get logs.
  • Removed precache plugin md file as they were mostly dev focused (all which are already in .go file) and/or outdated.
  • Streamlined logs and status messages to include job metadata
  • Updated precache resource name to be simply lca-prep-precache. This should indicate that the job is from Prep stage. This also means previously appended resource names (job or cm) are also dropped as they are redundant and they are both using the same name.
  • Updated extra-manifest warning annotation key to follow convention. <subsystem>.lca.openshift.io/warn-<name of the warning>
  • Addressed nits from prev PR

Ref:
#476
#498

/cc @donpenney @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pixelsoccupied
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@pixelsoccupied pixelsoccupied force-pushed the update-doc branch 2 times, most recently from 6671fad to e670cc6 Compare May 16, 2024 17:31
@pixelsoccupied
Copy link
Contributor Author

/hold
testing a little bit

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@openshift-ci-robot
Copy link

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32495, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Background / Context

This PR finalizes the work related Prep stage resiliency with docs + log messages + uniform naming convention

Things to note:

  • Cleaned up existing docs to reflect the updates better and helpful commands to get logs.
  • Removed precache plugin md file as they were mostly dev focused (all which are already in .go file) and/or outdated.
  • Streamlined logs and status messages to include job metadata
  • Updated precache resource name to be simply lca-prep-precache. This should indicate that the job is from Prep stage. This also means previously appended resource names (job or cm) are also dropped as they are redundant and they are both using the same name.
  • Updated extra-manifest warning annotation key to follow convention. <subsystem>.lca.openshift.io/warn-<name of the warning>
  • Addressed nits from prev PR
    (Strikethrough will be addressed in another PR)

Ref:
#476
#498

/cc @donpenney @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pixelsoccupied
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@jc-rh
Copy link
Member

jc-rh commented May 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@pixelsoccupied
Copy link
Contributor Author

the extramanifest clean up/nit covered in #521. wdyt about getting this PR in before 521?

@Missxiaoguo
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@donpenney
Copy link
Collaborator

/override ci/prow/integration

Copy link
Contributor

openshift-ci bot commented May 21, 2024

@donpenney: Overrode contexts on behalf of donpenney: ci/prow/integration

In response to this:

/override ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 54e971d into openshift-kni:main May 21, 2024
8 checks passed
@openshift-ci-robot
Copy link

@pixelsoccupied: Jira Issue OCPBUGS-32495 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Background / Context

This PR finalizes the work related Prep stage resiliency with docs + log messages + uniform naming convention

Things to note:

  • Cleaned up existing docs to reflect the updates better and helpful commands to get logs.
  • Removed precache plugin md file as they were mostly dev focused (all which are already in .go file) and/or outdated.
  • Streamlined logs and status messages to include job metadata
  • Updated precache resource name to be simply lca-prep-precache. This should indicate that the job is from Prep stage. This also means previously appended resource names (job or cm) are also dropped as they are redundant and they are both using the same name.
  • Updated extra-manifest warning annotation key to follow convention. <subsystem>.lca.openshift.io/warn-<name of the warning>
  • Addressed nits from prev PR
    (Strikethrough will be addressed in another PR)

Ref:
#476
#498

/cc @donpenney @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants