[release-4.13] OCPBUGS-31051: controller: kubelet: skip config with empty payload #886
Conversation
MCO's KubeletConfig can be sent with empty payload, for example
when configuring autosizing:
```
apiVersion: machineconfiguration.openshift.io/v1
kind: KubeletConfig
metadata:
name: autosizing-master
spec:
autoSizingReserved: true
machineConfigPoolSelector:
matchLabels:
pools.operator.machineconfiguration.openshift.io/master: ""
```
In general there's not much we can do when obeserving these
kubeletconfig objects anyway, so we skip them.
Please note: the control loop still depends on the fact there
1. is just one kubeletconfig object *with payload*
2. there's no merge logic
as it stands today both still should be core assumptions regarding
how MCO works.
Signed-off-by: Francesco Romani <fromani@redhat.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-30923 has been cloned as Jira Issue OCPBUGS-31051. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31051, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.12 |
|
@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-31051: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31051 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ffromani: new pull request created: #904 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #884
/assign ffromani