Bug 1967317: Do not create systemd update-rps service for veth devices #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cynepco3hahue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Pull Request Test Coverage Report for Build 1563
💛 - Coveralls |
cynepco3hahue
force-pushed
the
update_rps_oci_hook
branch
from
39b8960
to
ab0e39e
Compare
cynepco3hahue
changed the title
|
@cynepco3hahue: This pull request references Bugzilla bug 1967317, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@cynepco3hahue: This pull request references Bugzilla bug 1967317, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yanirq
reviewed
Jun 17, 2021
| netns_link_indexes=$(ip netns exec "${ns}" ip -j link | jq ".[] | select(.link_index != null) | .link_index") | ||
| for link_index in ${netns_link_indexes}; do | ||
| container_veth=$(ip -j link | jq ".[] | select(.ifindex == ${link_index}) | .ifname" | tr -d '"') | ||
| echo ${mask} > /sys/devices/virtual/net/${container_veth}/queues/rx-0/rps_cpus |
There was a problem hiding this comment.
is that the only path to be added ? rx-0 ?
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
Yes, I think we want to backport it. Has it been tested yet? |
I tested it on my cluster. @browsell Did you have a chance to run it on top of the SNO cluster? |
cynepco3hahue
force-pushed
the
update_rps_oci_hook
branch
from
ab0e39e
to
09d666c
Compare
The start and shutdown of big amount of pods will initiate creation of the systemd service that should update the new interfaces `rps_cpus` mask and can create an additional CPU load under the cluster. The PR introduces to changes that should prevent it: 1. The OCI hook will update the pod virtual interfaces RPS mask under the node. 2. Exclude veth devices from the udev rule. Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
cynepco3hahue
force-pushed
the
update_rps_oci_hook
branch
from
09d666c
to
9fecd2a
Compare
|
/lgtm |
|
We can not really on |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@cynepco3hahue: All pull requests linked via external trackers have merged: Bugzilla bug 1967317 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.8 |
|
@cynepco3hahue: #659 failed to apply on top of branch "release-4.8": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cynepco3hahue
pushed a commit
to cynepco3hahue/performance-addon-operators
that referenced
this pull request
Jun 23, 2021
…i_hook Bug 1967317: Do not create systemd update-rps service for veth devices (cherry picked from commit 33b9640) Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/performance-addon-operators
that referenced
this pull request
Nov 5, 2021
…i_hook Bug 1967317: Do not create systemd update-rps service for veth devices (cherry picked from commit 33b9640) Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Tal-or
added a commit
to Tal-or/cluster-node-tuning-operator
that referenced
this pull request
Oct 6, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
added a commit
to Tal-or/cluster-node-tuning-operator
that referenced
this pull request
Oct 6, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
added a commit
to Tal-or/cluster-node-tuning-operator
that referenced
this pull request
Oct 6, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/cluster-node-tuning-operator
that referenced
this pull request
Oct 10, 2022
* set RPS for veth on host level only RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com> * set-rps-mask: remove `find` Since we're dealing only with virtual devices here which has a single queue, we can set the RPS mask directly. Signed-off-by: Talor Itzhak <titzhak@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com> Co-authored-by: Yanir Quinn <yquinn@redhat.com>
Tal-or
added a commit
to Tal-or/cluster-node-tuning-operator
that referenced
this pull request
Nov 6, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
added a commit
to Tal-or/performance-addon-operators
that referenced
this pull request
Nov 23, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
added a commit
to Tal-or/performance-addon-operators
that referenced
this pull request
Nov 23, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
added a commit
to Tal-or/cluster-node-tuning-operator
that referenced
this pull request
Nov 23, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
added a commit
to Tal-or/performance-addon-operators
that referenced
this pull request
Nov 23, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/cluster-node-tuning-operator
that referenced
this pull request
Nov 24, 2022
RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Signed-off-by: Talor Itzhak <titzhak@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
IlyaTyomkin
pushed a commit
to IlyaTyomkin/cluster-node-tuning-operator
that referenced
this pull request
May 23, 2023
* set RPS for veth on host level only RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com> * set-rps-mask: remove `find` Since we're dealing only with virtual devices here which has a single queue, we can set the RPS mask directly. Signed-off-by: Talor Itzhak <titzhak@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com> Co-authored-by: Yanir Quinn <yquinn@redhat.com>
IlyaTyomkin
pushed a commit
to IlyaTyomkin/cluster-node-tuning-operator
that referenced
this pull request
Jun 13, 2023
* set RPS for veth on host level only RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (openshift-kni/performance-addon-operators#659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. Co-authored-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com> * set-rps-mask: remove `find` Since we're dealing only with virtual devices here which has a single queue, we can set the RPS mask directly. Signed-off-by: Talor Itzhak <titzhak@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com> Co-authored-by: Yanir Quinn <yquinn@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start and shutdown of big amount of pods will initiate the creation of the systemd
service that should update the new interfaces
rps_cpusmask and can create an additionalCPU load under the cluster.
The PR introduces to changes that should prevent it:
Signed-off-by: Artyom Lukianov alukiano@redhat.com