[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug 1985365: "re-activate stalld test and add new stalld priority test" #692

shajmakh · 2021-07-22T11:39:04Z

Back-porting PR #690 to release-4.8 branch

Now that bugzillas 1912118 and 1903302 got resolved, we can remove the skip from the stalld test again.

Following bugzillas 1960386 and 1905492 , now we have automated test that checks that stalld scheduling priority is higher than ksoftirq and rcu{c,b}

following the code review , I added error check for each strconv.atoi use.

openshift-ci · 2021-07-22T11:39:05Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-22T11:40:30Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2021-07-22T11:42:44Z

Pull Request Test Coverage Report for Build 1674

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.673%

Totals
Change from base Build 1632:	0.0%
Covered Lines:	1406
Relevant Lines:	1858

💛 - Coveralls

openshift-ci · 2021-07-22T11:46:02Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-22T12:24:05Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T12:24:16Z

/bugzilla refresh

openshift-ci · 2021-07-22T12:24:18Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-22T12:24:42Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T12:25:16Z

/bugzilla refresh

openshift-ci · 2021-07-22T12:25:17Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-22T12:41:32Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX: 1903302

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T12:41:58Z

/bugzilla refresh

openshift-ci · 2021-07-22T12:41:59Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-22T12:52:02Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX: remove skip from stalld test after resolving 1903302 and 1912118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T12:53:04Z

/bugzilla refresh

openshift-ci · 2021-07-22T12:53:05Z

@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T12:55:29Z

/bugzilla refresh

openshift-ci · 2021-07-22T12:55:32Z

@shajmakh: Bugzilla bug 1903302 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

qe_staff
redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T13:40:08Z

/bugzilla refresh

openshift-ci · 2021-07-22T13:40:13Z

@shajmakh: This pull request references Bugzilla bug 1905492, which is invalid:

expected the bug to be open, but it isn't
expected the bug to target the "4.8.0" release, but it targets "4.7.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead
expected Bugzilla bug 1905492 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-22T13:49:54Z

@shajmakh: This pull request references Bugzilla bug 1905492, which is invalid:

expected the bug to be open, but it isn't

expected the bug to target the "4.8.0" release, but it targets "4.7.0" instead

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

expected Bugzilla bug 1905492 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

@fromanirh @cynepco3hahue the bug is already verified for 4.7/4.6 should I clone it with target release 4.8 and open it ? and btw shouldn't I also back-port these changes to 4.7 & 4.6?

ffromani · 2021-07-22T14:27:21Z

@shajmakh: This pull request references Bugzilla bug 1905492, which is invalid:

expected the bug to be open, but it isn't

expected the bug to target the "4.8.0" release, but it targets "4.7.0" instead

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

expected Bugzilla bug 1905492 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

@fromanirh @cynepco3hahue the bug is already verified for 4.7/4.6 should I clone it with target release 4.8 and open it ? and btw shouldn't I also back-port these changes to 4.7 & 4.6?

I think you need a new bug to backport the test fixes. The bug which it's referenced is about the production code changes, and indeed it's already solved and shipped.

ffromani · 2021-07-22T14:28:52Z

/lgtm
/approve
actually let's see if the bot is happy in the current state. Being test fixes, I don't mind too much.

openshift-ci · 2021-07-22T14:28:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fromanirh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani · 2021-07-22T14:30:37Z

 Not mergeable. Should not have bugzilla/invalid-bug label.

nope, need to fix BZ :)

openshift-bot · 2021-07-23T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-07-23T01:00:55Z

@openshift-bot: This pull request references Bugzilla bug 1905492, which is invalid:

expected the bug to be open, but it isn't
expected the bug to target the "4.8.z" release, but it targets "4.7.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead
expected Bugzilla bug 1905492 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-23T14:05:26Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected the bug to target the "4.8.z" release, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1905492 to target a release in 4.9.0, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug 1985365: "re-activate stalld test and add new stalld priority test"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-23T14:07:13Z

/bugzilla refresh

openshift-ci · 2021-07-23T14:07:17Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected dependent Bugzilla bug 1905492 to target a release in 4.9.0, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-23T14:07:56Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected dependent Bugzilla bug 1905492 to target a release in 4.9.0, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

seems like we do need to create a bug for 4.9 & from it to clone a bug for 4.8

ffromani · 2021-07-23T14:10:51Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected dependent Bugzilla bug 1905492 to target a release in 4.9.0, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

seems like we do need to create a bug for 4.9 & from it to clone a bug for 4.8

not sure, it's a very peculiar corner case the one you are handling now.
Do you need the explicit dependency in the bug?

shajmakh · 2021-07-23T14:12:19Z

/bugzilla refresh

openshift-ci · 2021-07-23T14:12:22Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected the bug to target the "4.8.z" release, but it targets "4.9.0" instead
expected Bugzilla bug 1985365 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-23T14:13:36Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected the bug to target the "4.8.z" release, but it targets "4.9.0" instead

expected Bugzilla bug 1985365 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

I think it indeed needs a dependent bug

shajmakh · 2021-07-23T14:14:23Z

/bugzilla refresh

openshift-ci · 2021-07-23T14:14:26Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is invalid:

expected Bugzilla bug 1985365 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh · 2021-07-23T14:18:25Z

/bugzilla refresh

openshift-ci · 2021-07-23T14:18:36Z

@shajmakh: This pull request references Bugzilla bug 1985365, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1985371 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1985371 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-23T14:19:55Z

@shajmakh: All pull requests linked via external trackers have merged:

openshift-kni/performance-addon-operators#692

Bugzilla bug 1985365 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug 1985365: "re-activate stalld test and add new stalld priority test"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shajmakh added 3 commits July 22, 2021 13:54

e2e: Reactivate stalld test

8ae4c33

Now that bugzillas 1912118 and 1903302 got resolved, we can remove the skip from the stalld test again.

Cherry-pick "e2e: Add stalld scheduling priority test"

2cee6bb

Following bugzillas 1960386 and 1905492 , now we have automated test that checks that stalld scheduling priority is higher than ksoftirq and rcu{c,b}

e2e: Add error checks in stalld priority test

a4392dd

following the code review , I added error check for each strconv.atoi use.

openshift-ci bot requested review from cynepco3hahue and swatisehgal July 22, 2021 11:39

ffromani changed the title ~~Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690"~~ [release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Jul 22, 2021

shajmakh changed the title ~~[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690"~~ [release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX Jul 22, 2021

shajmakh changed the title ~~[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX~~ [release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX: Jul 22, 2021

shajmakh changed the title ~~[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX:~~ [release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug XXX: 1903302 Jul 22, 2021

openshift-ci bot assigned ffromani Jul 22, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 23, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 23, 2021

openshift-ci bot requested a review from gsr-shanks July 23, 2021 14:18

openshift-merge-robot merged commit 4fb7293 into openshift-kni:release-4.8 Jul 23, 2021

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug 1985365: "re-activate stalld test and add new stalld priority test" #692

[release-4.8] Cherry picked from PR "e2e: Add stalld test and remove no longer needed skips #690" Bug 1985365: "re-activate stalld test and add new stalld priority test" #692

Conversation

shajmakh commented Jul 22, 2021 • edited

openshift-ci bot commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

coveralls commented Jul 22, 2021

Pull Request Test Coverage Report for Build 1674

💛 - Coveralls

openshift-ci bot commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

shajmakh commented Jul 22, 2021

ffromani commented Jul 22, 2021

ffromani commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

ffromani commented Jul 22, 2021

openshift-bot commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

shajmakh commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

shajmakh commented Jul 23, 2021

ffromani commented Jul 23, 2021

shajmakh commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

shajmakh commented Jul 23, 2021

shajmakh commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

shajmakh commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

openshift-ci bot commented Jul 23, 2021

shajmakh commented Jul 22, 2021 •

edited