OCPBUGS-19676: Allow agent VSphere installs by simulating VMWare host #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the platform type is "vsphere", set the host's manufacturer to VMWare in order to pass the assisted-service validations and allow the installation to proceed.
bfournie
force-pushed
the
agent-vsphere-platform
branch
from
adfe1d0
to
751cade
Compare
|
New changes are detected. LGTM label has been removed. |
rwsu
approved these changes
Nov 2, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Nov 2, 2023
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Nov 2, 2023
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Nov 8, 2023
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Nov 9, 2023
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Nov 9, 2023
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Nov 9, 2023
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Jan 3, 2024
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Jan 30, 2024
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Feb 21, 2024
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
rwsu
added a commit
to rwsu/dev-scripts
that referenced
this pull request
Feb 26, 2024
Fake credentials are added to install-config.yaml for vSphere platform. In combination with openshift-metal3#1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2024
Fake credentials are added to install-config.yaml for vSphere platform. In combination with #1588, this patch allows testng of installer and assisted-service validations for the vSphere platform. A complete install for vSphere using dev-scripts is currently not possible because the vSphere environment is partially simulated using libvirt VMs. Any cloud controller manager interactions with vSphere will fail in libvirt because there isn't an actual vSphere environment that is being exercised. In this setup, only "agent wait-for bootstrap-complete" will succeed. For vSphere, "agent wait-for install-complete" will fail and is skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the platform type is "vsphere", set the host's manufacturer to VMWare in order to pass the assisted-service validations and allow the installation to proceed.