Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22417: Include extra manifests when building configImage #1598

Merged

Conversation

bfournie
Copy link
Contributor

When building the configImage, the extra manifests were not being added to the directory where it was built.

When building the configImage, the extra manifests were not being added
to the directory where it was built.
@bfournie
Copy link
Contributor Author

/cc @danielerez

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

@bfournie: GitHub didn't allow me to request PR reviews from the following users: danielerez.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @danielerez

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor Author

/cc @rwsu @andfasano

@openshift-ci openshift-ci bot requested review from andfasano and rwsu October 26, 2023 01:32
@andfasano
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

@bfournie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack d8c6e34 link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@bfournie
Copy link
Contributor Author

bfournie commented Nov 2, 2023

/retest-required

@openshift-ci openshift-ci bot merged commit d702dc9 into openshift-metal3:master Nov 2, 2023
4 of 5 checks passed
@bfournie bfournie deleted the config-image-extra-manifest branch November 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants